[PATCH] gtk: listbox border was not rendered

Ivan Timofeev timofeev.i.s at gmail.com
Fri Jul 27 10:39:40 PDT 2012


Hi!

there was a discussion about ugly listboxes in gtk theming, and we
decided to draw a border:

http://nabble.documentfoundation.org/PATCH-Revert-Set-the-listbox-height-to-an-integer-multiple-of-the-listbox-entry-height-tp3969374p3980299.html

and after a more than 2 month *cough* I have figured out what is wrong.
The problem is in gtk plugin which does some weird things when drawing
a listbox (see the description in the patch).
I have no idea why it does that, git blame shows that it is from the
initial import. It would be great if someone review the patch, I am
absolutely not sure.

The famous before.png and after.png are attached.

Thanks!

Ivan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-gtk-listbox-border-was-not-rendered.patch
Type: text/x-diff
Size: 5178 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120727/7866a3a5/attachment-0001.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: after.png
Type: image/png
Size: 45223 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120727/7866a3a5/attachment-0002.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: before.png
Type: image/png
Size: 45194 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120727/7866a3a5/attachment-0003.png>


More information about the LibreOffice mailing list