[PUSHED][REVIEW 3-6] fdo#43989 Automatic restart on Windows

Noel Power nopower at suse.com
Mon Jul 30 08:36:16 PDT 2012


pushed ( didn't runtime check as no windows build, otoh I trust stephan 
did test it and the patch looks good  )

Noel

On 30/07/12 11:04, Stephan Bergmann wrote:
> Backporting the fix for 
> <https://bugs.freedesktop.org/show_bug.cgi?id=51252> "LO cannot start 
> (reports runtime error with Visual C++ Runtime Library)" to LO 3.6.0 
> (which causes LO to routinely try to restart itself now after an 
> upgrade on Windows) unfortunately revealed that the fix 
> <http://cgit.freedesktop.org/libreoffice/core/commit/?id=55836370ffb70a34b888f81cdacdfede8fee29cf> 
> "fdo#43989: Revert 'win32-dont-attempt-restart.diff: Don't attempt to 
> restart OOo after crash'" for 
> <https://bugs.freedesktop.org/show_bug.cgi?id=43989> "After 
> installation first launch terminates after splash screen" should have 
> been backported as well.  (And the latter undoes a broken fix that has 
> been corrected on master with 
> <http://cgit.freedesktop.org/libreoffice/core/commit/?id=b5ad981518f4407243f89507b2561dd0b1ef28ee> 
> "bnc#524250: Show backing component after cancelled recovery.")
>
> The net effect is that, on Windows, the first start of LO 3.6.0 (both 
> a completely new installation, as well as after an upgrade from older 
> versions) silently terminates after the splash screen. The user needs 
> to start LO anew.  While this is unfortunate, it is IMO only a minor 
> annoyance with a trivial workaround, so does not warrant yet another 
> LO 3.6.0 RC5.  (See 
> <https://bugs.freedesktop.org/show_bug.cgi?id=51252#c58>.)
>
> So, please review for cherry-picking into libreoffice-3-6 the two commits
>
> <http://cgit.freedesktop.org/libreoffice/core/commit/?id=b5ad981518f4407243f89507b2561dd0b1ef28ee> 
> "bnc#524250: Show backing component after cancelled recovery"
>
> and
>
> <http://cgit.freedesktop.org/libreoffice/core/commit/?id=55836370ffb70a34b888f81cdacdfede8fee29cf> 
> "fdo#43989: Revert 'win32-dont-attempt-restart.diff: Don't attempt to 
> restart OOo after crash'."
>
> Thanks,
> Stephan
> _______________________________________________
> LibreOffice mailing list
> LibreOffice at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
>



More information about the LibreOffice mailing list