[PUSHED] Re: [PATCH] Convert various SV_DECL_PTRARR in SFX2 module

Michael Stahl mstahl at redhat.com
Fri Jun 8 13:59:37 PDT 2012


On 07/06/12 16:57, Noel Grandin wrote:
> Hi
> 
> These patches convert various SV_DECL_PTRARR stuff to std::set and 
> std::vector in the SFX2 module.
> 
> Passes "make check" at global level, and compiled with debug=true

thanks, pushed.

patch #1 had a DeleteAndDestroy method that didn't actually delete,
which i actually failed to notice while reviewing, but then it caused
sc_unoapi to crash in ScRefreshTimer::Timeout in a hard to reproduce
way, took some time to track that down...



More information about the LibreOffice mailing list