big Deps ...

Stephan Bergmann sbergman at redhat.com
Thu Jun 21 04:47:57 PDT 2012


On 06/21/2012 10:57 AM, Michael Meeks wrote:
> On Wed, 2012-06-20 at 18:28 +0200, Stephan Bergmann wrote:
>> IIRC, the logic of cppumaker is to first generate temporary .hpp and
>> .hdl files and only copy them over existing ones in solver if they are
>> actually different.  That way, it should easily happen that a .hdl file
>> is updated while the corresponding .hpp file is not.  (For example, when
>
> 	Fair enough; but we could presumably easily tweak that such that a .hdl
> and .hpp would be updated in lock-step; after all if the .hpp is not
> changed - it necessarily includes the .hdl - so we didn't really gain
> anything from not touching the .hpp :-)

Yeah, could probably be done.

> 	[ indeed, I'm sure there is one - but what is the benefit of separating
> the .hdl files out, if we are sure that each .hpp will include all of
> it's dependent .hpp's ? ].

Circular dependencies among headers.

>>> 	Then again a small number of files include .hdl files directly;
>>> is that a bug ? :-)
>>
>> Looks like a bug, yes.  Care to share the list?
>
> 	Nice; it's easier to generate than send:
>
> 	git grep 'include.*\.hdl'
>
> 	only 127 instances luckily.

Feel free to make that into an EasyHack.

Stephan


More information about the LibreOffice mailing list