[REVIEW 3-5][REVIEW 3-6] fdo#47636 font fallback performance regression

Michael Meeks michael.meeks at suse.com
Thu Jun 21 09:21:06 PDT 2012


Hi there,

On Thu, 2012-06-21 at 16:20 +0100, Caolán McNamara wrote:
> So 8c023fd645c8b83637ffcde4055886b2e4f94393 should fix a performance
> regression with font fallback under fontconfig using platforms when a
> font is missing.
>
> This may be a duplicate of MAB fdo#44719. Fontconfig is fairly slow on
> finding a replacement font so proposed solution is to cache the results.

	You have my +1 for both branches (no need for review for -3-6 for this
regression / bug IMHO) ;-) The patch is also a lot simpler when
considering the revert of the original cache logic.

	I'll push it in a bit if no-one else has - just building -3-5 currently
to test the performance improvement.

	Thanks !

		Michael.

-- 
michael.meeks at suse.com  <><, Pseudo Engineer, itinerant idiot



More information about the LibreOffice mailing list