fdo 50950 make (ISO)WEEKNUM comply with ODFF1.2, advise asked

Winfried Donkers W.Donkers at dci-electronics.nl
Mon Jun 25 00:53:29 PDT 2012


Hi Eike,



> Please see my Splinter review in
> https://bugs.freedesktop.org/show_bug.cgi?id=50950#c3

I will do that. (I hope my contributions don't cost you too much time in correcting so that they fit well in the general picture...)

> It seems one point didn't make it across: I did not suggest to create yet
> another (internal) WEEKNUM function. 

I did start with keeping WEEKNUM_ADD in the Add-in module, but as I had diffuculties in using the Date::getWeekofYear function (getting the null date right), I simply thought keeping WEEKNUM and ISOWEEKNUM together would be logical - disrepecting pre-ODFF1.2 and interoperability issues.
I will go back to your original plan and upload another diff file to the bugs.feedesktop.org (with corrections as taken from your Splinter review).
 
> I'll come back to the compiler details later. The problem there may be
> mapping from internal (ISOWEEKNUM) to Add-In (WEEKNUM).

I am a bit busy with other projects at the time, so don't hurry for my sake :-)

Winfried


More information about the LibreOffice mailing list