[PUSHED][PATCH] Prevent print settings dialog to show help button when it's called from help window

Caolán McNamara caolanm at redhat.com
Tue Jun 26 07:59:28 PDT 2012


On Tue, 2012-06-26 at 15:06 +0200, Maxime de Roucy wrote:
> Here is the a new 0003 and 0004 without the bug.

ok, so pushed 3 and 4 to master now. Thanks for this.

It seems odd that we have *two* methods in SfxPrinter, IsKnown and
IsOriginal that both return bKnown and are so equivalent. Maybe we
should delete one of the blasted things.

The original detection of being called from an API call was odd, esp
with the rollback of "i'm from the api if i have parameters, except if i
have one parameter and it's print-selection". So to me pre 3 and post 3
*seem* equivalent except for the addition of the new property, but its a
bit of a rats nest of code :-)

C.



More information about the LibreOffice mailing list