[PATCH][PUSHED] update cppunit to version 1-13

Markus Mohrhard markus.mohrhard at googlemail.com
Thu Jun 28 01:57:11 PDT 2012


Hellp Philipp

2012/6/28 Philipp Riemer <ruderphilipp at gmail.com>:
> Hey Markus, Michael, all,
>
> Two minor things from my side as a newbie to the LO project:
>
> (1) In lines 288-291 of the patch you also delete the comment showing
> from where you got the CPPUNIT file. Might be helpful to keep the
> URL...

The URL is wrong now. Our cppunit version is from
http://cgit.freedesktop.org/libreoffice/cppunit/log/ so I don't think
that we need this URL now.

>
> (2) In addition, I was wondering why the install folder is still
> "ooo-install" in the makefile (lines 321-257)? Backward compatibility
> reasons?
>

Why should we make a riskful change to something that is clearly
working as it should. IMHO changing internal names without a good
reason is not a good idea.

Patches is already pushed because Michael needed it for his rebasing.

Regards,
Markus


More information about the LibreOffice mailing list