[PATCH] fdo#45678: EasyHack: kill hwpfilter/source/list.hxx with fire

Michael Meeks michael.meeks at suse.com
Mon Mar 5 01:54:31 PST 2012


Hi there,

On Fri, 2012-03-02 at 16:39 +0100, Dézsi Szabolcs wrote:
> diff --git a/hwpfilter/source/grammar.cxx
> b/hwpfilter/source/grammar.cxx
> index 2285aab..99c2f3c 100644
> --- a/hwpfilter/source/grammar.cxx
> +++ b/hwpfilter/source/grammar.cxx
> @@ -909,291 +910,291 @@ yyreduce:
>  
>  case 1:
>  #line 60 "grammar.y"
> -{ yyval.ptr = new Node(ID_IDENTIFIER); allocValue(yyval.ptr->value ,
> yyvsp[0].str); debug("Identifier : %s\n",yyvsp[0].str);
> nodelist.insert(yyval.ptr); ;
> +{ yyval.ptr = new Node(ID_IDENTIFIER); allocValue(yyval.ptr->value ,
> yyvsp[0].str); debug("Identifier : %s\n",yyvsp[0].str);
> nodelist.push_back(yyval.ptr); ;
>      break;}
>  case 2:

	etc. etc. I never noticed we had this generated grammar (apparently)
without the original .y file to re-generate it from - that's pretty
sucky. I wonder how it happened.

	Then again, with only ~70 states, it looks like a reasonably tractible
grammar to unwind & re-write.

	Regards,

		Michael.

-- 
michael.meeks at suse.com  <><, Pseudo Engineer, itinerant idiot



More information about the LibreOffice mailing list