[REVIEW 3-5-1] fix for fdo#46825, crash copying a chart

Michael Meeks michael.meeks at suse.com
Mon Mar 5 03:29:40 PST 2012


On Fri, 2012-03-02 at 22:13 -0500, Kohei Yoshida wrote:
> > [1] fixes a crash when you copy a chart in the document. The problem
> > is that you should not create a uno::Sequence with new because the
> > uno::Sequence copy c'tor is creating a flat copy. This will later
> > result in a double delete.
> >
> > I think the patch is quite save and fixes a crash and therefore should
> > be included into at least 3-5 and if still possible in 3-5-1.
> 
> > [1] http://cgit.freedesktop.org/libreoffice/core/commit/?id=8f2d3c47ad40039a842fa09d98137155dcfdfe9e
> 
> The change looks safe.  Pushed to the 3-5 branch with my sign-off.

	Ack from me too, trivial, safe fix fixing a crasher, fine for me on
-3-5-1, one more review needed.

	ATB,

		Michael.

-- 
michael.meeks at suse.com  <><, Pseudo Engineer, itinerant idiot



More information about the LibreOffice mailing list