[PUSHED][PATCH]fdo45671 writer par. bg color simplified code for split button

Ivan Timofeev timofeev.i.s at gmail.com
Tue Mar 6 08:04:48 PST 2012


Hi Winfried,

On 06.03.2012 11:50, Winfried Donkers wrote:
> Ivan Timofeev wrote (5 maart 2012 18:08)
>> 1. Open a new Writer doc
>> 2. Type smth
>> 3. Press the "Background Color" button
>>     ->  nothing happens (?)
> That is expected behaviour to me. The startup background colur is transparent (hence the gray bitmap in the button).

I expected the background would be gray...

>> 4. Select some color from the picker
>>     ->  ok, it works
>> 5. Select "No Fill"
>>     ->  nothing happens
> That is not OK.
> I put back the original (pre fdo44611 patch) code and that restored the wanted behaviour.
> Do you want me to submit a separate fix for this (easiest for me) or do you wanty me to resubmit the patch (which will have to wait till the end of the day then and will need some experimenting with git)?

No, let me do it myself. :) I simply wanted to submit that to your approval.

http://cgit.freedesktop.org/libreoffice/core/commit/?id=f57e65477038e0151e1d69599351173ed2fdd044
http://cgit.freedesktop.org/libreoffice/core/commit/?id=ee77e4a776de74de06ffb51ebe3a9f597e532e8a

Thanks,
Ivan


More information about the LibreOffice mailing list