current master build on linux is borked

Matúš Kukan matus.kukan at gmail.com
Tue Mar 6 14:47:01 PST 2012


On 6 March 2012 18:17, Takeshi Abe <tabe at fixedpoint.jp> wrote:
> So I doubt 90491a073c5b5faee782ad5eab63276fda2342e6.
> In my case (gmake 3.81 on Debian wheezy) reverting it makes `make sal`
> work again.

Oh no, I guess I should start to use make 3.81 when doing such changes.

Unfortunately I don't know how to fix that.
make 3.81 just can't behave. It ignores the trailing '/' in $(OUTDIR)/%/ :
and I think it ignores even more (everything after % ?).

I created attached patch where
+$(OUTDIR)/% :
+   $(if $<,$(call gb_Deliver_deliver,$<,$@),mkdir -p $@)
was supposed to solve problems (and maybe bring others).

Then there was problem with cppunittester because it's in special
directory, but well, I can skip mentioning that. Can be solved.

The next problem is again with picking wrong rules:
$(gb_Library_OUTDIRLOCATION)/%$(gb_Library_PLAINEXT) :
    $(call gb_Helper_abbreviate_dirs,\
        $(call gb_Deliver_deliver,$<,$@) \
            $(foreach target,$(AUXTARGETS), && $(call
gb_Deliver_deliver,$(dir $<)/$(notdir $(target)),$(target))))

make 3.81 can't prefer this rule over the first seen $(OUTDIR)/% :
even if it is more specific (longer prefix and also there is suffix specified)

So I am giving up on hope I can hack around misbehaving of make 3.81
and we most probably want to revert nice improvement in
90491a073c5b5faee782ad5eab63276fda2342e6

Matus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-fix-for-make-3.81.patch
Type: text/x-patch
Size: 6048 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120306/9d42ba27/attachment.bin>


More information about the LibreOffice mailing list