Unused code patches

Lubos Lunak l.lunak at suse.cz
Mon Mar 19 13:26:52 PDT 2012


On Monday 19 of March 2012, David T. Biedrzycki wrote:
> Hello,
> These patches are very small and pretty simple. The following patches
> are contributed
> under the LGPLv3+ / MPL.
>
> IIT's newly founded ACM is starting some work on open source project and
> this is our first start. Attached are some patches that remove

 It appears that you do not use a mail client that warns when you forget to 
actually attach them :).

> some unnecessary code. We do have a question though, how up to date is the
> unusedcode.easy file?

 It is re-generated manually AFAIK. According to the log, it was last updated 
5 days ago.

> There are *many* methods that have already been 
> removed that are still listed. If we are missing something, please let us
> know, otherwise, we have been working on, and have almost finished,
> automating a process to remove methods from that file that no longer exist
> in the source.

 That will not work reliably, unless your process also verifies that they are 
really unused in all configurations. The list is generated from one 
configuration and a manual check is needed that each item is indeed unused.

-- 
 Lubos Lunak
 l.lunak at suse.cz


More information about the LibreOffice mailing list