Cppcheck reports "Logical conjunction always evaluates to false" in text_gfx.cxx

julien2412 serval2412 at yahoo.fr
Mon Mar 19 14:25:00 PDT 2012


Here is a patch :
http://nabble.documentfoundation.org/file/n3840411/text_gfx_patch.txt
text_gfx_patch.txt 

remarks :
- I replaced this 
    nChar >= 0xff62 && nChar < 0xff64
by this for readability
    nChar == 0xff62 || nChar == 0xff63 
- I added in the outer "if", "nChar == 0xffe3" because if not, "nChar ==
0xffe3" in the inner "if" is useless.

Is this patch ok ?
If yes, I can commit and push it on master.

Julien

--
View this message in context: http://nabble.documentfoundation.org/Cppcheck-reports-Logical-conjunction-always-evaluates-to-false-in-text-gfx-cxx-tp3836511p3840411.html
Sent from the Dev mailing list archive at Nabble.com.


More information about the LibreOffice mailing list