[PUSHED][PATCH] Remove unused code

Caolán McNamara caolanm at redhat.com
Tue Mar 20 13:37:34 PDT 2012


On Tue, 2012-03-20 at 21:26 +0100, Chr. Rossmanith wrote:
> A PresenterAnimation could be instantiated here
> 
>      ModeChangeAnimation (
>          const ::boost::shared_ptr<PresenterSprite>& rpSprite,
>          const Reference<rendering::XSpriteCanvas>& rxCanvas)
>          : PresenterAnimation (0, 1000, 20),
>            mpSprite(rpSprite),
>            mxCanvas(rxCanvas)
>      {
>      }
> 
> in PresenterWindowManager.cxx - iff ModeChangeAnimation would be used 
> anywhere. I can't find any place where it is used. Double check would be 
> nice. So first ModeChangeAnimation would have to go, then 
> PresenterAnimation could be removed as well.

Yup, callcatcher is correct here. ModeChangeAnimation itself is all
inlines and itself is never instantiated so gcc doesn't even emit any
ModeChangeAnimation code, so both it and PresenterAnimation can go. 

I'd actually ModeChangeAnimation chopped out here locally, I've pushed
that now with the last unused-code update

C.



More information about the LibreOffice mailing list