Another Dalvik oddity: "bogus byte value: 128" while processing DNDConstants.class

Norbert Thiebaud nthiebaud at gmail.com
Wed Mar 28 10:51:44 PDT 2012


On Wed, Mar 28, 2012 at 8:12 AM, Tor Lillqvist <tml at iki.fi> wrote:
> The patch below seems to help. OK to commit? I'm looking at you, Stephan;)
>
> --tml
>
> diff --git a/codemaker/source/javamaker/javatype.cxx
> b/codemaker/source/javamaker/javatype.cxx
> index 1453122..f297980 100644
> --- a/codemaker/source/javamaker/javatype.cxx
> +++ b/codemaker/source/javamaker/javatype.cxx
> @@ -2447,7 +2447,10 @@ void addConstant(
>                 rtl::OString(
>                     RTL_CONSTASCII_STRINGPARAM("Bad type
> information"))); //TODO
>         }
> -        valueIndex = classFile->addIntegerInfo(fieldValue.m_value.aByte);
> +        if (fieldValue.m_value.aByte < 0x80)

^^^
doesn't
valueindex = classFile->addIntegerInfo((sal_Int8)fieldValue.m_mvalue.aByte))
enough ?

Norbert


More information about the LibreOffice mailing list