[PATCH] Re: 1 sheet by default [was Re: Tinderbox failure, Linux-RHEL6-x86_64 at 14-with-check, MASTER, last success: 2012-05-15 18:12:02]

[Stefan Knorr (Astron)]

Hello Kendy, Stephan,

thanks for your help and pushing this (and the original patch).


> The approach looks rather sane to me (and apparently to Kendy also, who
> already pushed).  In general, the qadevOOo based tests are rather a mess,
> and nobody loves them.  However, they proved useful in finding regressions
> over and over again, so we should see to keep them working until newer,
> better tests replace their code coverage (and even go beyond).

Ah, ok.

> I just extended your approach of explicitly inserting an additional sheet to
> qadevOOo/tests/java/mod/_sc/ScModelObj.java (see
> <http://cgit.freedesktop.org/libreoffice/core/commit/?id=0210ec32f779bb2098657eb4ad69cca7a60835dc>
> "Fix one more test that implicitly assumes more than one Calc sheet") and it
> appears to work well.

Oh. Good.

Regards,
Astron.