[Libreoffice-commits] update string copy semantics to be undefined in a non-crashing way

Caolán McNamara caolanm at redhat.com
Thu Oct 4 04:07:55 PDT 2012


On Thu, 2012-10-04 at 11:34 +0200, Stephan Bergmann wrote:
> > +        OSL_FAIL( "Out of bounds substring access" );
> 
> New code should use SAL_WARN, please.  (Arguably, it should rather use 
> abort.  Which would also make the following code moot.)
> 
> > +        IMPL_RTL_STRINGNAME( newFromLiteral )( ppThis, "!!br0ken!!", 10, 0 );

make it an assert, but leave the following code in for the NDEBUG case ?

C.



More information about the LibreOffice mailing list