Cppcheck report in vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx

[julien2412]

Ivan Timofeev wrote
> On 20.10.2012 22:23, julien2412 wrote:
>> [gdi/salnativewidgets-gtk.cxx:3452] ->
>> [gdi/salnativewidgets-gtk.cxx:3462]:
>> (performance) Variable 'eState' is reassigned a value before the old one
>> has
>> been used.
>> Is the line 3452 could just be removed or should this part be a little
>> reworked?
> I think the line 3452 can be removed. GTK_STATE_ACTIVE is for "pressed"
> controls, i.e. CTRL_STATE_PRESSED, and the Slider control does not even
> use this CTRL_STATE_PRESSED flag.
> http://opengrok.libreoffice.org/xref/core/vcl/source/control/slider.cxx

Hi Ivan,

Thank you for your feedback Ivan, I pushed this removal on master (see
http://cgit.freedesktop.org/libreoffice/core/commit/?id=b339e4e2ba2b833903956cbcebf64a2a99dba176)

Julien



--
View this message in context: http://nabble.documentfoundation.org/Cppcheck-report-in-vcl-unx-gtk-gdi-salnativewidgets-gtk-cxx-tp4014513p4014579.html
Sent from the Dev mailing list archive at Nabble.com.