[PATCH] warn free build of dmake, concat-deps and lpsolve

[René Kjellerup (via_Code_Review)]

Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/903

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/03/903/1

warn free build of dmake, concat-deps and lpsolve

I've added a correct if test to silence compiler warnings like this:
"warning: ignoring return value of 'fread', declared with attribute warn_unused_result"
or
"warning: ignoring return value of 'fwrite', declared with attribute warn_unused_result"

In lpsolve via a new patch:
Moved from  "fprintf(output, (char* variable))" to "fputs((char* variable), output)"
because of a compiler warning that it couldn't varify the format string because it wasn't a
string literal.
and correctly redid the the ECHO macro from '(void)fwrite(...)' to 'do { if(fwrite(...)) {} } while(0)'
because it's clear that we tried to cast a size_t to void meaning we do not care about the
return of fwrite in this case.

Change-Id: I1137160d28461fbac69c8e05d32ba010da491c57
---
M dmake/unix/arlib.c
M helpcontent2
A lpsolve/lp_solve-fixed-warn.patch
M lpsolve/makefile.mk
M solenv/bin/concat-deps.c
5 files changed, 87 insertions(+), 6 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/903
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1137160d28461fbac69c8e05d32ba010da491c57
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: René Kjellerup <rk.katana.steel at gmail.com>