[REVIEWED 3-6] fdo#56325 - Every simple fix for pivot table's database query bug

David Tardon dtardon at redhat.com
Wed Oct 31 01:01:41 PDT 2012


Hi,

On Tue, Oct 30, 2012 at 09:01:01PM -0400, Kohei Yoshida wrote:
> Hi there,
> 
> I'd like to have the attached patch pushed to the 3-6 branch in order to fix
> 
> https://bugs.freedesktop.org/show_bug.cgi?id=56325
> 
> This patch is basically an equivalent of
> 
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=acfdd93f31ae59bb688c27d2fd57e1940a6b9370
> 
> on master, but due to my earlier indentation fix, it won't simply be
> cherry-picked to the 3-6 branch. But the two changes are basically the same
> change minus the indentation difference.
> 
> The punch line of this fix is that I just forgot to build the tree of
> flat_segment_tree before it was searched in isRowActive().  That ended up
> filtering out all the records incorrectly for the database data source,
> which would end up with an empty table output.

+1 from me.

D.


More information about the LibreOffice mailing list