[PUSHED: 3-6][REVIEW-3-6] don't use uninitialized global variable in lotus filter

David Tardon dtardon at redhat.com
Sun Sep 9 22:36:38 PDT 2012


Hi,

On Sun, Sep 09, 2012 at 05:30:50PM +0200, Markus Mohrhard wrote:
> Hey,
> 
> [1] fixes a crash opening lotus files. This regression has been
> introduced by c75e2ed27d5da71891ed7a148ff9603c58eaa58e. The global
> variable pLotusRoot is not yet assigned. I removed the use of the
> global variable in the problematic class and replaced it with a local
> variable.

Pushed. One nitpick: the new constructors should be explicit, because I
do not think automatic conversion is desirable here (but the potential
for accidental misuse is probably very low in this case).

D.


More information about the LibreOffice mailing list