[PATCH libreoffice-4-0] pgsql-sdbc: ResultSetMetaData::getTableName return tablename...

Lionel Elie Mamane (via Code Review) gerrit at gerrit.libreoffice.org
Thu Apr 11 08:06:54 PDT 2013


Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/3343

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/43/3343/1

pgsql-sdbc: ResultSetMetaData::getTableName return tablename (without schema)

Change-Id: I319ba91045fa43922d7b694a4f13322295590c81
---
M connectivity/source/drivers/postgresql/pq_resultsetmetadata.cxx
1 file changed, 1 insertion(+), 10 deletions(-)



diff --git a/connectivity/source/drivers/postgresql/pq_resultsetmetadata.cxx b/connectivity/source/drivers/postgresql/pq_resultsetmetadata.cxx
index f6089cc..6d9abf9 100644
--- a/connectivity/source/drivers/postgresql/pq_resultsetmetadata.cxx
+++ b/connectivity/source/drivers/postgresql/pq_resultsetmetadata.cxx
@@ -407,16 +407,7 @@
 {
     (void) column;
 // LEM TODO This is very fishy.. Should probably return the table to which that column belongs!
-    rtl::OUString ret;
-    if( m_tableName.getLength() )
-    {
-        OUStringBuffer buf( 128 );
-        buf.append( m_schemaName );
-        buf.appendAscii( "." );
-        buf.append( m_tableName );
-        ret = buf.makeStringAndClear();
-    }
-    return ret;
+    return m_tableName;
 }
 
 ::rtl::OUString ResultSetMetaData::getCatalogName( sal_Int32 column )

-- 
To view, visit https://gerrit.libreoffice.org/3343
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I319ba91045fa43922d7b694a4f13322295590c81
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Lionel Elie Mamane <lionel at mamane.lu>



More information about the LibreOffice mailing list