dbaccess::ODatabaseContext cleaning its cache "too late"?

Stephan Bergmann sbergman at redhat.com
Tue Aug 20 01:57:06 PDT 2013


On 08/16/2013 03:46 PM, Lionel Elie Mamane wrote:
> On Fri, Aug 16, 2013 at 02:55:35PM +0200, Stephan Bergmann wrote:
>> No real insight into any of this, but would it make sense to rely on
>> some explicit "commit" stimulus to do that committing, instead of
>> doing it upon "dispose"
>
> I don't understand what "commit stimulus" is.

I was thinking of some "close" function (analogous to how, say, a Java 
class representing a file should have an explicit close() method rather 
than relying on a finalizer).

>> (or at least take into account m_bModified and not try to commit if
>> not necessary?).
>
> This seems to make sense; embedded hsqldb are a bit weird because they
> save some files (the ones in database/) "automatically" even without
> user "save" action. I *hope* that this does not clobber m_bModified if
> *other* changes are pending (e.g. creation / modification of a report
> / form / ...). I wouldn't be *too* surprised if the "save even when
> m_bModified == false" was to work around a putative "m_bModified is
> clobbered wrongly" issue.

(Just to make it clear: I don't plan to follow up on this with any 
patches; just wanted to bring it up.)

Stephan



More information about the LibreOffice mailing list