About parenthesis problem in testintrosp.cxx

Lubos Lunak l.lunak at suse.cz
Mon Jan 21 03:02:32 PST 2013


On Saturday 19 of January 2013, julien2412 wrote:
> Hello,
>
> Here's a problem in stoc/test/testintrosp.cxx, line 182
> aRetStr = aRetStr + OUString( OUString(" (Typ: ") ) + xIdlClass->getName()
> + OUString(""));
>
> By taking a look at git history, I found that it was:
> aRetStr = aRetStr + OUString( OUString(RTL_CONSTASCII_USTRINGPARAM(" (Typ:
> ")) ) + xIdlClass->getName() + OUString(RTL_CONSTASCII_USTRINGPARAM(")"));
> before 02/06/2012

 Presumably whoever did this used regular expressions to do the change and 
didn't get this one quite right.

> If testintrosp.cxx is still used, an idea how to make this line more clear
> (and perhaps removing the double use of OUString)?

 aRetStr += " (Typ: " + xIdlClass->getName() + ")";

-- 
 Lubos Lunak
 l.lunak at suse.cz


More information about the LibreOffice mailing list