Change in core[libreoffice-4-0]: we need to parse the cell address after import, fdo#59843

[Markus Mohrhard (via Code Review)]

Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/1944

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/44/1944/1

we need to parse the cell address after import, fdo#59843

Otherwise we may have problems with sheet names from sheets that are not
yet imported.

Change-Id: I99a6507567b7d1018b790a90019cd563fa7323a0
---
M sc/source/filter/xml/xmlcondformat.cxx
1 file changed, 2 insertions(+), 4 deletions(-)



diff --git a/sc/source/filter/xml/xmlcondformat.cxx b/sc/source/filter/xml/xmlcondformat.cxx
index ae0c2d7..443361a 100644
--- a/sc/source/filter/xml/xmlcondformat.cxx
+++ b/sc/source/filter/xml/xmlcondformat.cxx
@@ -567,12 +567,10 @@
     rtl::OUString aExpr2;
     ScConditionMode eMode;
     GetConditionData(sExpression, eMode, aExpr1, aExpr2);
-    ScAddress aPos;
-    sal_Int32 nIndex = 0;
-    ScRangeStringConverter::GetAddressFromString(aPos, sAddress, GetScImport().GetDocument(), formula::FormulaGrammar::CONV_ODF, nIndex);
 
-    ScCondFormatEntry* pFormatEntry = new ScCondFormatEntry(eMode, aExpr1, aExpr2, GetScImport().GetDocument(), aPos, sStyle,
+    ScCondFormatEntry* pFormatEntry = new ScCondFormatEntry(eMode, aExpr1, aExpr2, GetScImport().GetDocument(), ScAddress(), sStyle,
                                                         rtl::OUString(), rtl::OUString(), formula::FormulaGrammar::GRAM_ODFF, formula::FormulaGrammar::GRAM_ODFF);
+    pFormatEntry->SetSrcString(sAddress);
 
     pFormat->AddEntry(pFormatEntry);
 }

-- 
To view, visit https://gerrit.libreoffice.org/1944
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I99a6507567b7d1018b790a90019cd563fa7323a0
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Markus Mohrhard <markus.mohrhard at googlemail.com>