[PATCH] fdo#43460 startmath,codemaker: use isEmpty()

Jelle van der Waa (via Code Review) gerrit at gerrit.libreoffice.org
Mon Jun 17 08:30:52 PDT 2013


Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/4318

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/18/4318/1

fdo#43460 startmath,codemaker: use isEmpty()

Change-Id: I55d3f4546f40a321ebf4b08db33536592f451944
---
M codemaker/source/codemaker/global.cxx
M starmath/inc/visitors.hxx
2 files changed, 2 insertions(+), 2 deletions(-)



diff --git a/codemaker/source/codemaker/global.cxx b/codemaker/source/codemaker/global.cxx
index 4324cb6..645fd06 100644
--- a/codemaker/source/codemaker/global.cxx
+++ b/codemaker/source/codemaker/global.cxx
@@ -135,7 +135,7 @@
         if( nIndex == -1 )
             break;
 
-        if (buffer.getLength() == 0 || OString(".") == buffer.getStr())
+        if (buffer.isEmpty() || OString(".") == buffer.getStr())
         {
             buffer.append(token);
             continue;
diff --git a/starmath/inc/visitors.hxx b/starmath/inc/visitors.hxx
index d864c45..ef21763 100644
--- a/starmath/inc/visitors.hxx
+++ b/starmath/inc/visitors.hxx
@@ -477,7 +477,7 @@
     }
     /** Append a blank for separation, if needed */
     inline void Separate( ){
-        if( !aCmdText.getLength() || aCmdText[ aCmdText.getLength() - 1 ] != ' ' )
+        if( aCmdText.isEmpty() || aCmdText[ aCmdText.getLength() - 1 ] != ' ' )
             aCmdText.append(' ');
     }
     /** Output text generated from the pNodes */

-- 
To view, visit https://gerrit.libreoffice.org/4318
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I55d3f4546f40a321ebf4b08db33536592f451944
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Jelle van der Waa <jelle at vdwaa.nl>



More information about the LibreOffice mailing list