--enable-pch option is broken?

Lubos Lunak l.lunak at suse.cz
Tue Mar 12 09:07:05 PDT 2013


On Sunday 10 of March 2013, Peter Foley wrote:
> David,
>
> Should be fixed now.
> you can just run ./solenv/bin/update_pch.sh to auto-regenerate all the pch
> files.
> Maybe a note should be added somewhere to run it whenever header files are
> moved around?

 That is not necessary, as it was the commit doing the change that was broken. 
PCH headers are not really that special, in this regard they are normal 
headers and could/should have been changed together with all the other 
changes. Such manual changes will of course be overwritten by next 
update_pch.sh run, but incorrect #include directives should not be left in 
the sources, one way or another.

-- 
 Lubos Lunak
 l.lunak at suse.cz


More information about the LibreOffice mailing list