[PATCH] WaE: control might reach end of non-void function ... being ...

Christian Lohmaier (via Code Review) gerrit at gerrit.libreoffice.org
Sun Mar 17 11:56:04 PDT 2013


Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/2803

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/03/2803/1

WaE: control might reach end of non-void function ... being inlined

The warning is bogus, but the change is minimal

Change-Id: I2bc6ec57d271e14e5abe8f152338626771458fb5
---
M sw/source/filter/ww8/writerhelper.hxx
1 file changed, 2 insertions(+), 2 deletions(-)



diff --git a/sw/source/filter/ww8/writerhelper.hxx b/sw/source/filter/ww8/writerhelper.hxx
index 3d45b43..4768a3e 100644
--- a/sw/source/filter/ww8/writerhelper.hxx
+++ b/sw/source/filter/ww8/writerhelper.hxx
@@ -182,8 +182,8 @@
                 return (maGrf == rOther.maGrf);
             else if ((!mbForBullet) && (!rOther.mbForBullet))
                 return (mpFlyFrm == rOther.mpFlyFrm);
-            else
-                return false;
+
+            return false;
         }
 
         /** The Size of the contained element

-- 
To view, visit https://gerrit.libreoffice.org/2803
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2bc6ec57d271e14e5abe8f152338626771458fb5
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Christian Lohmaier <lohmaier+LibreOffice at googlemail.com>



More information about the LibreOffice mailing list