About coverity 440107 (keyimpl.cxx in registry)

julien2412 serval2412 at yahoo.fr
Sat Mar 23 05:00:13 PDT 2013


Thank you Stephan for your feedback.

If I remove these cases in the switch, I've got this:
/home/julien/compile-libreoffice/libo/registry/source/keyimpl.cxx: In member
function ‘RegError ORegKey::getValue(const rtl::OUString&, RegValue) const’:
/home/julien/compile-libreoffice/libo/registry/source/keyimpl.cxx:622:12:
error: enumeration value ‘RG_VALUETYPE_LONGLIST’ not handled in switch
[-Werror=switch]
/home/julien/compile-libreoffice/libo/registry/source/keyimpl.cxx:622:12:
error: enumeration value ‘RG_VALUETYPE_STRINGLIST’ not handled in switch
[-Werror=switch]
/home/julien/compile-libreoffice/libo/registry/source/keyimpl.cxx:622:12:
error: enumeration value ‘RG_VALUETYPE_UNICODELIST’ not handled in switch
[-Werror=switch]

It seems either we clean up the whole thing or we let as it is. Of course,
there's also disabling warning for a specific part but I dislike doing this
if it's not a strong external constraint (just personal opinion of course
:-)).

In brief, except if we have a go to clean up the whole thing (after all why
not take advantage we're on 4.0?), I'll let as it is.

Julien



--
View this message in context: http://nabble.documentfoundation.org/About-coverity-440107-keyimpl-cxx-in-registry-tp4045470p4045542.html
Sent from the Dev mailing list archive at Nabble.com.


More information about the LibreOffice mailing list