[PATCH libreoffice-3-6] fdo#57079: SvxSuperContourDlg: unregister configuration list...

Michael Stahl (via Code Review) gerrit at gerrit.libreoffice.org
Fri May 17 05:35:32 PDT 2013


Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/3941

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/41/3941/1

fdo#57079: SvxSuperContourDlg: unregister configuration listener

... in destructor.  Otherwise it will access freed memory when
eventually called.  This crashes since OOo 3.2 but no idea why it would
appear to not crash in earlier versions.

Change-Id: Ie3ab7ddf19fb1086f0b7d824555ab6b063e2b9ad
(cherry picked from commit fc63700181ab0f42eab5f98328074fe1682344f8)
---
M svx/source/dialog/_contdlg.cxx
1 file changed, 2 insertions(+), 0 deletions(-)



diff --git a/svx/source/dialog/_contdlg.cxx b/svx/source/dialog/_contdlg.cxx
index ddc11ed..39f6325 100644
--- a/svx/source/dialog/_contdlg.cxx
+++ b/svx/source/dialog/_contdlg.cxx
@@ -283,6 +283,8 @@
 
 SvxSuperContourDlg::~SvxSuperContourDlg()
 {
+    SvtMiscOptions aMiscOptions;
+    aMiscOptions.RemoveListenerLink( LINK(this, SvxSuperContourDlg, MiscHdl) );
 }
 
 // Resize methods

-- 
To view, visit https://gerrit.libreoffice.org/3941
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie3ab7ddf19fb1086f0b7d824555ab6b063e2b9ad
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Michael Stahl <mstahl at redhat.com>



More information about the LibreOffice mailing list