[PATCH] Fix memory leak in DrawViewShell::GetAttrState().

Mark Wielaard (via Code Review) gerrit at gerrit.libreoffice.org
Fri May 24 00:45:52 PDT 2013


Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/4020

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/20/4020/1

Fix memory leak in DrawViewShell::GetAttrState().

DrawViewShell::GetAttrState() might create a temporary new SvxNumRule
object. Make sure it gets deleted when done.

Change-Id: I33ddd9df983193fe87dd076267043d202cdfc3d5
---
M sd/source/ui/view/drviewsf.cxx
1 file changed, 2 insertions(+), 1 deletion(-)



diff --git a/sd/source/ui/view/drviewsf.cxx b/sd/source/ui/view/drviewsf.cxx
index 4989cd2..89c90d0 100644
--- a/sd/source/ui/view/drviewsf.cxx
+++ b/sd/source/ui/view/drviewsf.cxx
@@ -630,9 +630,10 @@
                             }
                         }
                     }
+                  delete pNumRule;
                 }
             }
-                    break;
+            break;
             //End
             // Added by Li Hui for story 179.
             case FN_NUM_BULLET_ON:

-- 
To view, visit https://gerrit.libreoffice.org/4020
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I33ddd9df983193fe87dd076267043d202cdfc3d5
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Mark Wielaard <mark at klomp.org>



More information about the LibreOffice mailing list