[Bug 72598] [Easyhack] Remove SunStudio cruft from code base

Philipp Riemer ruderphilipp at gmail.com
Sat Jan 4 03:06:01 PST 2014


Hi,
In commit 9eac4a5<http://cgit.freedesktop.org/libreoffice/core/commit/?id=66397a4fd222757a8bd651c0c297615319eac4a5>
Jelle
changed the following:
diff --git a/cppu/source/uno/data.cxx b/cppu/source/uno/data.cxx
index f6f7b1e..b6b4a05 100644
--- a/cppu/source/uno/data.cxx<http://cgit.freedesktop.org/libreoffice/core/tree/cppu/source/uno/data.cxx?id=b1d65c9f1535c9ef283d2a91a225359e5983f747>
+++ b/cppu/source/uno/data.cxx<http://cgit.freedesktop.org/libreoffice/core/tree/cppu/source/uno/data.cxx?id=66397a4fd222757a8bd651c0c297615319eac4a5>
@@ -351,7 +351,7 @@ CPPU_DLLPUBLIC sal_Bool SAL_CALL
uno_type_isAssignableFromData(
 #if (defined(INTEL) \
&& (defined(__GNUC__) && (defined(LINUX) || defined(FREEBSD) ||
defined(NETBSD) || defined(OPENBSD)) \
- || defined(MACOSX) || defined(DRAGONFLY) || (defined(__SUNPRO_CC) &&
defined(SOLARIS)))) \
+ || defined(MACOSX) || defined(DRAGONFLY) || )) \
|| defined(IOS)
#define MAX_ALIGNMENT_4
#endif

Now I was wondering, if the empty OR at the end might bring any
complications? Wouldn't it be better to remove these characters as well? I
submitted a change request to gerrit:
https://gerrit.libreoffice.org/#/c/7269/

Cheers!
Philipp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20140104/e5e4814b/attachment.html>


More information about the LibreOffice mailing list