FontCharMap change - request for comment

[Chris Sherlock]

Hi all,

As many of you know, I'm particularly interested in VCL and how it fits
together. One thing I've noticed is that a lot of VCL classes have their
own built-in reference counting code.

I am interested in changing this situation. In
https://gerrit.libreoffice.org/#/c/11565/4 I used a shared_ptr, but I have
since switched to use boost's intrusive_ptr

I am interested in someone looking at my general approach. In a nutshell, I
have kept a reference counter variable in FontCharMap, and merged
ImplFontCharMap with FontCharMap. I have also used a typedef
PtrFontCharMap, which is intrusive_ptr<FontCharMap>.

I would love to see some comments, good or bad so that I can start rolling
out this sort of thing to other parts of the VCL module.

Chris
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20140924/8b736260/attachment.html>