[Libreoffice-commits] core.git: basic/source "Revert a fix that can never have worked in the first place?"

[Noel Power]

On 09/09/15 09:05, David Tardon wrote:
> Hi,
>
> On Tue, Sep 08, 2015 at 11:05:20AM +0200, Stephan Bergmann wrote:
>> or what
>> "Allow Input as symbol for action option compatible" shall even mean:
> I suppose it means using
>
> Option Compatible
>
> statement in the basic code.
yes it's to do with Compatiblity mode (and thus also VBASupport which
iirc implicitly sets the compatability mode),  note: I know nothing
about this fix or associated issue. But wont that codel now error out
with 'syntax error' where it would have previously passed assuming the
mode and token values matched ? Might make more sense to change the
conditional inside the 'if( SbiTokenizer::IsKwd( eTok ) ) ' test to
error out as appropriate (but not make the useless token assignment

Noel
>
> D.
> _______________________________________________
> LibreOffice mailing list
> LibreOffice at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice