New Defects reported by Coverity Scan for LibreOffice

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

3 new defect(s) introduced to LibreOffice found with Coverity Scan.
2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)


** CID 1358429:  Null pointer dereferences  (REVERSE_INULL)
/sd/source/ui/unoidl/unomodel.cxx: 2442 in SdXImpressDocument::postMouseEvent(int, int, int, int, int, int)()


________________________________________________________________________________________________________
*** CID 1358429:  Null pointer dereferences  (REVERSE_INULL)
/sd/source/ui/unoidl/unomodel.cxx: 2442 in SdXImpressDocument::postMouseEvent(int, int, int, int, int, int)()
2436     void SdXImpressDocument::postMouseEvent(int nType, int nX, int nY, int nCount, int nButtons, int nModifier)
2437     {
2438         SolarMutexGuard aGuard;
2439     
2440         DrawViewShell* pViewShell = GetViewShell();
2441         Window* pWindow = pViewShell->GetActiveWindow();
>>>     CID 1358429:  Null pointer dereferences  (REVERSE_INULL)
>>>     Null-checking "pViewShell" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
2442         if (!pViewShell)
2443             return;
2444     
2445         Point aPos(Point(convertTwipToMm100(nX), convertTwipToMm100(nY)));
2446         MouseEvent aEvent(aPos, nCount,
2447                 MouseEventModifiers::SIMPLECLICK, nButtons, nModifier);

** CID 1358428:  Null pointer dereferences  (REVERSE_INULL)
/vcl/opengl/texture.cxx: 404 in OpenGLTexture::FillCoords<(unsigned int)4>(std::vector<float, std::allocator<float>> &, const SalTwoRect &, bool) const()


________________________________________________________________________________________________________
*** CID 1358428:  Null pointer dereferences  (REVERSE_INULL)
/vcl/opengl/texture.cxx: 404 in OpenGLTexture::FillCoords<(unsigned int)4>(std::vector<float, std::allocator<float>> &, const SalTwoRect &, bool) const()
398         GLfloat y1 = 0.0f;
399         GLfloat y2 = 0.0f;
400     
401         double fTextureWidth(mpImpl->mnWidth);
402         double fTextureHeight(mpImpl->mnHeight);
403     
>>>     CID 1358428:  Null pointer dereferences  (REVERSE_INULL)
>>>     Null-checking "this->mpImpl" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
404         if (mpImpl)
405         {
406             x1 = (maRect.Left() + rPosAry.mnSrcX) / fTextureWidth;
407             x2 = (maRect.Left() + rPosAry.mnSrcX + rPosAry.mnSrcWidth) / fTextureWidth;
408     
409             if (bInverted)

** CID 1358427:  Null pointer dereferences  (NULL_RETURNS)
/sd/source/ui/unoidl/unomodel.cxx: 2440 in SdXImpressDocument::postMouseEvent(int, int, int, int, int, int)()


________________________________________________________________________________________________________
*** CID 1358427:  Null pointer dereferences  (NULL_RETURNS)
/sd/source/ui/unoidl/unomodel.cxx: 2440 in SdXImpressDocument::postMouseEvent(int, int, int, int, int, int)()
2434     }
2435     
2436     void SdXImpressDocument::postMouseEvent(int nType, int nX, int nY, int nCount, int nButtons, int nModifier)
2437     {
2438         SolarMutexGuard aGuard;
2439     
>>>     CID 1358427:  Null pointer dereferences  (NULL_RETURNS)
>>>     Assigning: "pViewShell" = null return value from "GetViewShell".
2440         DrawViewShell* pViewShell = GetViewShell();
2441         Window* pWindow = pViewShell->GetActiveWindow();
2442         if (!pViewShell)
2443             return;
2444     
2445         Point aPos(Point(convertTwipToMm100(nX), convertTwipToMm100(nY)));


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/libreoffice?tab=overview

To manage Coverity Scan email notifications for "libreoffice at lists.freedesktop.org", click https://scan.coverity.com/subscriptions/edit?email=libreoffice%40lists.freedesktop.org&token=d6481d718a775246b2340f282ebe5939