ScInterpreter::ScGCD and ScInterpreter::ScLCM

[Eike Rathke]

Hi Filippo,

On Wednesday, 2017-01-04 15:15:08 +0000, Filippo giacchè wrote:

> > > What are commit like this ?
> > > http://cgit.freedesktop.org/libreoffice/core/commit/?id=
> > 32950e9089aa323303154156c27f713ba3efdf85
> >
> > That implements a unit test for the GCD() function, which is executed
> > during build time to ensure the function works as intended.
> >
> 
> if i change the function I also reimplement the test?

No, you keep the test untouched. If it fails after changes then it
usually means the change was wrong. Only adding more specific test cases
could be appropriate.

However, as already mentioned in this thread, the task is less about
changing individual interpreter functions but rather work on the
ScMatrix internal representation accesses.

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GPG key "ID" 0x65632D3A - 2265 D7F3 A7B0 95CC 3918  630B 6A6C D5B7 6563 2D3A
Better use 64-bit 0x6A6CD5B765632D3A here is why: https://evil32.com/
Care about Free Software, support the FSFE https://fsfe.org/support/?erack
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/libreoffice/attachments/20170104/d9051bb7/attachment.sig>