AtomicCounter::is_always_lock_free on armel

Stephan Bergmann sbergman at redhat.com
Thu Nov 7 09:18:06 UTC 2019


On 06/11/2019 18:39, Rene Engelhard wrote:
> Given the introduced AtomicCounter is used later, too I tried the simplified
> 
> diff --git a/vcl/inc/opengl/zone.hxx b/vcl/inc/opengl/zone.hxx
> index 3210186c3096..13ac3bf6793e 100644
> --- a/vcl/inc/opengl/zone.hxx
> +++ b/vcl/inc/opengl/zone.hxx
> @@ -36,7 +36,9 @@ class VCL_DLLPUBLIC OpenGLZone {
>       // increasing, so will eventually overflow, so the underlying type better be unsigned, which
>       // sig_atomic_t is not guaranteed to be:
>       using AtomicCounter = std::atomic<std::make_unsigned_t<std::sig_atomic_t>>;
> +#if !defined ARM32 && !defined __ARM_PCS_VFP
>       static_assert(AtomicCounter::is_always_lock_free);
> +#endif
>   
>       /// how many times have we entered a GL zone
>       static AtomicCounter gnEnterCount;
> 
> (atking that define from bridges...)
> 
> and that builds...
> 
> -> https://gerrit.libreoffice.org/#/c/82165/

I don't understand your "Given the introduced AtomicCounter is used 
later..." reasoning above, but commented at 
<https://gerrit.libreoffice.org/#/c/82165/> "disable static_assert on 
AtomicCounter::is_always_lock_free on armel ..." now.



More information about the LibreOffice mailing list