How to deal with dpi-dependent values in unit tests?

[Tomaž Vajngerl]

Hi Regina,

On Fri, Oct 15, 2021 at 1:29 PM Regina Henschel <rb.henschel at t-online.de>
wrote:

> Hi all,
>
> the values of the bound rectangle of a Fontwork shape are dpi dependent
> (I don't know why). I could increase the tolerance to cover more dpi
> settings as done in https://gerrit.libreoffice.org/c/core/+/123613 or I
> add
>      if (!IsDefaultDPI()) return;
> as done in https://gerrit.libreoffice.org/c/core/+/123512
>
> What is the preferred way to handle it?
>

If you can get away with IsDefaultDPI, then use that (you can't always).
Technically we shouldn't be dependent on DPI when we deal with logical
units, so until we find where the bug is that makes that DPI dependent,
only the default DPI (96) should return the correct results (I think).

Kind regards
> Regina
>

Best Regards, Tomaž
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice/attachments/20211016/3240df6e/attachment.htm>