ESC meeting minutes: 2022-02-24

Miklos Vajna vmiklos at collabora.com
Thu Feb 24 15:38:41 UTC 2022


* Present:
     + Sophie, Stephan, Michael S, Ilmari, Hossein, Gabriel, Cloph, Caolan, Heiko, Miklos, Olivier, Xisco, Aron, Kendy, Eike

* Completed Action Items:
     + add a note to the https://wiki.documentfoundation.org/Development/Environment_variables wiki page to have prefixes (to prevent collision) + think twice before adding a new one (Hossein)
       + review of the new page is appreciated
     + go back to have a prefix for NO_QUERYSAVE (Heiko)

* Pending Action Items:
     + None

* Release Engineering update (Cloph)
     + 7.3 status: 7.3.1 rc2 was tagged, builds are in progress
     + 7.2 status: 7.2.6 rc2 in 1 week
     + Remotes: Android, iOS
     + Android viewer

* Documentation (Olivier)
     + New Help
        + Improvements in search scope (Ilmari)
     + HelpContents2
        + New pages (ohallot)
        + Fixes (flywire, S. Horacek, M Kaganski)
     + Guides
        + Published Getting Started Guide 7.3. (J. Weber)
        + Published Turkish translation (Ayhan Yalçinsoy)
        + Work/update for other guides 7.3 started (Team)
     + Calc functions wiki articles have received dozens of small fixes in the past weeks (Ilmari)
        + https://wiki.documentfoundation.org/Documentation/Calc_Functions/List_of_Functions
        + thanks to Dutch translator Henk van der Burg for input and suggestions
     + Bugzilla Documentation statistics
         240(240) bugs open
     + Updates:
         BZ changes   1 week    1 month    3 months   12 months
            created     12(-3)     46(-5)    126(1)      331(-2)
          commented     15(-19)   117(-39)   421(-33)   1650(-2)
           resolved      3(-1)     15(-2)     61(2)      202(1)
     + top 10 contributors:
           Olivier Hallot made 71 changes in 1 month, and 585 changes in 1 year
           Heiko Tietze made 22 changes in 1 month, and 86 changes in 1 year
           Kaganski, Mike made 15 changes in 1 month, and 100 changes in 1 year
           Rafael Lima made 13 changes in 1 month, and 372 changes in 1 year
           Nabet, Julien made 13 changes in 1 month, and 62 changes in 1 year
           Xisco Fauli made 11 changes in 1 month, and 91 changes in 1 year
           Michael Warner made 9 changes in 1 month, and 10 changes in 1 year
           Seth Chaiklin made 8 changes in 1 month, and 123 changes in 1 year
           Alain Romedenne made 6 changes in 1 month, and 35 changes in 1 year
           Stéphane Guillou made 6 changes in 1 month, and 30 changes in 1 year


* UX Update (Heiko)
     + Bugzilla (topicUI) statistics
         260(260) (topicUI) bugs open, 96(96) (needsUXEval) needs to be evaluated by the UXteam
     + Updates:
         BZ changes   1 week   1 month   3 months   12 months
              added      4(2)     10(2)     15(2)       58(-3)
          commented     52(-3)   241(8)    656(7)     2804(-6)
            removed      2(-1)     6(-1)    13(1)       36(1)
           resolved      7(-7)    48(0)    107(2)      402(-1)
     + top 10 contributors:
           Heiko Tietze made 246 changes in 1 month, and 1941 changes in 1 year
           Seth Chaiklin made 26 changes in 1 month, and 129 changes in 1 year
           Foote, V Stuart made 20 changes in 1 month, and 479 changes in 1 year
           Dieter made 17 changes in 1 month, and 255 changes in 1 year
           Rafael Lima made 16 changes in 1 month, and 52 changes in 1 year
           Ilmari Lauhakangas made 14 changes in 1 month, and 295 changes in 1 year
           kabilo made 12 changes in 1 month, and 21 changes in 1 year
           Thomas Lendo made 11 changes in 1 month, and 40 changes in 1 year
           *UNKNOWN* made 10 changes in 1 month, and 10 changes in 1 year
           Albrecht Müller made 9 changes in 1 month, and 11 changes in 1 year

    + 3 new tickets since Feb/17
      [Bug 147540] Feature request: Rotate entire PDF document in Draw
         => WF
      [Bug 147524] Enhancement request: switch location of "Increase Indent" and
           "Decrease Indent" icons on Writer toolbar
         => easyhack
      [Bug 132589] Caption frame doesn't shrink 'in ratio' (empty space at the bottom)
         => NAB (NEEDINFO)

* Crash Testing (Caolan)
     + 13(+0) import failure, 6(+0) export failures
     + 320 coverity issues
       - new coverity version
       - handful of new good issues
       - lots of bogus looking things, std::unique_ptr::reset() unaware ?
     + 16 ossfuzz issues
       - hwpfuzzer was fuzzing only parse, not parse+import
     + CVE-2021-25636 Incorrect trust validation of signature with ambiguous KeyInfo children announced

* Crash Reporting (Xisco)
    + https://crashreport.libreoffice.org/stats/version/7.2.5.2
          + (+318) 2096 1778 1776 1707 1860 1608 1246 691 0

      - https://crashreport.libreoffice.org/stats/signature/rtl::str::assign%3C_rtl_uString%3E(_rtl_uString%20*%20*,_rtl_uString%20*)

          - Crashtesting run didn't find anything.

          - xlsx import for the most part


    + https://crashreport.libreoffice.org/stats/version/7.3.0.3
          + (+360) 2744 2384 2260 347 0

     - https://crashreport.libreoffice.org/stats/signature/SwDrawBaseShell::GetState(SfxItemSet%20&)

     - It should be fixed in 7.3.1

     - Thanks to Julien


      - https://crashreport.libreoffice.org/stats/signature/SwNodeIndex::SwNodeIndex(SwNodeIndex%20const%20&,o3tl::strong_int%3Clong,Tag_SwNodeOffset%3E)
        - Related to ded965e82b11f527376bb9c2e7157288cbd08499 ?
        - Michael Stahl ?



* Mentoring/EasyHack update (Hossein)
           committer...   1 week     1 month     3 months    12 months
                   open      97(50)     146(52)     177(27)      215(11)
                reviews     488(140)   1540(144)   3596(98)    12396(296)
                 merged     344(73)    1400(52)    3991(43)    15085(340)
              abandoned      24(8)       73(11)     202(5)       712(24)
            own commits     247(44)    1067(-7)    3041(-24)   12581(-7)
         review commits      73(-2)     329(-16)    901(-46)    3964(13)
         contributor...   1 week     1 month     3 months    12 months
                   open      40(24)      59(31)     101(26)      184(3)
                reviews     872(172)   3258(132)   8820(46)    33350(658)
                 merged      10(-11)     82(-18)    243(-24)    1609(9)
              abandoned       0(-4)      23(-3)      56(-1)      435(0)
            own commits      14(-17)    113(-17)    338(-43)    1719(-26)
         review commits       0(0)        0(0)        0(0)         0(0)
     + easyHack statistics:
        needsDevEval 8(8)   needsUXEval 1(1)   cleanup_comments 289(289)
        total 341(341)   assigned 27(27)   open 286(286)
     + top 10 contributors:
           Johnny_M made 50 patches in 1 month, and 884 patches in 1 year
           Attila Bakos made 5 patches in 1 month, and 30 patches in 1 year
           Po-Yen Huang made 4 patches in 1 month, and 12 patches in 1 year
           Kevin Suo made 4 patches in 1 month, and 35 patches in 1 year
           Renwa Hiwa made 3 patches in 1 month, and 3 patches in 1 year
           Donkers, Winfried made 2 patches in 1 month, and 4 patches in 1 year
           Nagy Tibor made 2 patches in 1 month, and 34 patches in 1 year
           Ahmet, Hakan Çelik made 2 patches in 1 month, and 7 patches in 1 year
           Michael Warner made 2 patches in 1 month, and 6 patches in 1 year
           jwtiyar nariman made 2 patches in 1 month, and 2 patches in 1 year
     + top 10 reviewers:
           Michael Stahl made 138 review comments in 1 month, and 1032 in 1 year
           Adolfo Jayme Barrientos made 136 review comments in 1 month, and 956 in 1 year
           Thorsten Behrens made 136 review comments in 1 month, and 720 in 1 year
           Xisco Fauli made 114 review comments in 1 month, and 878 in 1 year
           Kaganski, Mike made 92 review comments in 1 month, and 820 in 1 year
           Olivier Hallot made 88 review comments in 1 month, and 1312 in 1 year
           Vajna, Miklos made 70 review comments in 1 month, and 598 in 1 year
           Rathke, Eike made 62 review comments in 1 month, and 316 in 1 year
           Nabet, Julien made 62 review comments in 1 month, and 516 in 1 year
           Bergmann, Stephan made 58 review comments in 1 month, and 230 in 1 year
     + Patches automatically abandoned:
         tdf#137818 Add Vary colors by point checkbox for chart data series ( Gabor Kelemen )
             - https://gerrit.libreoffice.org/#/c/114996

     + big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
           Deepika Sreejesh
           Momoko Hayashi
           Tushar Jham
+ 3 new contributors, 10 merged commits (all code related)
+ New blog post
   Adding a new UNO command
   https://dev.blog.documentfoundation.org/2022/02/23/adding-a-new-uno-command/
   + feedback appreciated

* GSoC (Ilmari)
     + GSoC 2022 application is filed
     + https://developers.google.com/open-source/gsoc/timeline
     + next step: 7th March: accepted orgs are announced
     + just waiting for now (Thorsten)

* Dev Guide was imported into our wiki (thanks to Guilhem for pushing the button) (Ilmari)
   + https://wiki.documentfoundation.org/Documentation/DevGuide/OpenOffice.org_Developers_Guide
   + lots of easy initial cleanup done (product name etc.)
   + would like to try bigger articles, maybe even one per chapter
   + new idl template created https://wiki.documentfoundation.org/Template:Idl
     + sadly needs tedious manual work as Doxygen URLs have "service" or "interface" as a bonus
   + this is problematic <idlm>com.sun.star.accessibility.XAccessibleComponent:getBounds</idlm>
     + getBounds there adds an anchor like so: https://www.openoffice.org/api/docs/common/ref/com/sun/star/accessibility/XAccessibleComponent.html#getBounds
     + our Doxygen currently creates unpredictable anchors like: https://api.libreoffice.org/docs/idl/ref/interfacecom_1_1sun_1_1star_1_1accessibility_1_1XAccessibleComponent.html#a61f2f4b0c2f1d355de2920cc984fe76a
     + mst said: there was an option that we wanted to use but it was removed in odk: remove PREDICTABLE_URLS from doxygen config - https://git.libreoffice.org/core/commit/15b53976e5d119877e53f34b34cee33a5f2883fd
because upstream didn't accept that patch
     + mst thinks this "docs/idl/ref/servicecom" problem was also fixed by PREDICTABLE_URL
     + patches in https://sourceforge.net/p/doxygen/mailman/doxygen-develop/thread/5183D2D1.7000000%40redhat.com/#msg30802342 and https://sourceforge.net/p/doxygen/mailman/doxygen-develop/thread/51A6175A.5040308%40redhat.com/#msg30909505
     + would be nice to link this from the Documentation or Development page (Miklos)
     + links from DevGuide to api.libreoffice.org? (Hossein)
       + that still has to be sorted out (Ilmari)
       + also the anchors are currently a hash, see above
     + api.libreoffice.org is at 7.2, is that intentional? (Hossein)
       + not really intention, but can be seen as tracking "still" (Cloph)
AI: update to 7.3 (Cloph)
     + could keep the old versions? (Hossein)
       + probably have enough resources, but how do users notice the old versions? (Cloph)
       + could perhaps manually link old versions
   + What edits are allowed for the DevGuide? (Kendy)
     + e.g. AOO-inherited branding
     + fine to change it (Ilmari)
     + perhaps delay it till we settle down

* Commit Access
   + None

* Developer Certification (Stephan/Kendy/Thorsten/László)
   + resting since: 8 weeks (limit: 20 weeks)

* Jenkins / CI update (Cloph)
     from:Thu Feb 17 15:01:50 2022
     master linux rel  jobs: 152 ok: 143 ko:   9 fail ratio:  5.92 % break:   6 broken duration: 3.24%
     master linux dbg  jobs: 134 ok: 123 ko:  11 fail ratio:  8.21 % break:  10 broken duration: 7.03%
     master mac rel    jobs: 121 ok: 120 ko:   1 fail ratio:  0.83 % break:   1 broken duration: 1.43%
     master mac dbg    jobs: 132 ok: 131 ko:   1 fail ratio:  0.76 % break:   1 broken duration: 0.05%
     master win rel    jobs: 124 ok: 124 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 0.00%
     master win dbg    jobs: 134 ok: 134 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 0.00%
     master win64 dbg  jobs: 127 ok: 127 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 0.00%
     master gerrit lin jobs: 578 ok: 509 ko:  41 fail ratio:  7.09% time for ok: mean:  18 median:  15
     master gerrit plg jobs: 587 ok: 354 ko: 205 fail ratio: 34.92% time for ok: mean:  42 median:  39
     master gerrit win jobs: 641 ok: 443 ko: 156 fail ratio: 24.34% time for ok: mean:  49 median:  44
     master gerrit mac jobs: 586 ok: 480 ko:  59 fail ratio: 10.07% time for ok: mean:  35 median:  31
     master android    jobs: 537 ok: 429 ko:  78 fail ratio: 14.53% time for ok: mean:  19 median:  14
     master gerrit all jobs: 609 ok: 303 ko: 255 fail ratio: 41.87% time for ok: mean:  72 median:  52
    + https://dev-www.libreoffice.org/tmp/gerrit_220224.html
    + tests that failed more than twice in last seven days
       3 CppunitTest_sc_jumbosheets_test                gerrit_windows
       3 CppunitTest_sw_layoutwriter2                gerrit_windows
       3 CppunitTest_sw_ooxmlexport5                gerrit_windows
       3 UITest_calc_tests8                gerrit_linux_clang_dbgutil
       3 UITest_impress_demo                gerrit_linux_clang_dbgutil
       5 CppunitTest_sw_ooxmlexport7                gerrit_windows
       5 UITest_calc_tests3                gerrit_linux_clang_dbgutil
      10 CppunitTest_sc_macros_test                gerrit_windows
      18 Killed by the kill-wrapper                gerrit_linux_clang_dbgutil
   + this week: nothing major
   + CppunitTest_sc_macros_test fails on slower Windows machines from time to time
     + only 30% of last week's failures
   + one builder ran out of diskspace
   + have a new mac builder (intel macbook pro)
     + little slower than the mac pro
   + have an additional linux builder upcoming
   + python rebuild failure: python would crash when used build-time (Stephan)
     + feedback appreciated wrt this helps or not with the failing TB
   + do we have an M1 builder for the CI? (Kendy)
     + yes, we have one (Cloph)
     + but it compiles for intel
     + plan arm builds as part of gerrit CI? (Kendy)
       + not yet, but TDF will buy some more HW in the future (Cloph)

* l10n (Sophie)
   + investigating some missing suggestions from translation memory in Weblate
   + new Romanian contributor

* Various baseline bumps (Stephan)
   + clang updates on Linux:
     + are we worried about disk space usage on the builders for the old clang version?
     + not removed at the moment, to help building on old branches
     + should not be a problem (Cloph)
   + Update on bumping macOS build baseline to Xcode 12.5 and macOS 11.0
     + tb69 can't be updated at the moment (Cloph)
     + could disable this box + proceed
     + Cloph will take the bot offline + the change can be then pushed

* What’s cooking (Miklos)
   + Lubos is working towards non-experimental jumbo sheets in Calc
     + hopes to enable 16k cols as non-experimental on master soon
     + intention is to have more feedback, early
   + feature/sparklines (Tomaz)
     + Excel-style small line charts in a cell
   + now that the devguide is imported, now will probably remove idlc from SDK (Stephan)
     + 7.4 already deprecates these tools (idlc, regmerge, etc.)

* QA update (Xisco)

     + UNCONFIRMED: 1694 (+6)
         + enhancements: 272  (+7)
         + needsUXEval: 0 (-2)
         + haveBackTrace: 5 (-1)
         + needsDevAdvice: 24 (-1)
         + documentation:  4 (-1)
         + android:  1 (+0)
         + iOS:  0 (+0)
         + Online:  10 (+0)

     + Most pressing bugs:
      New:

         None

      Old:
         + macOS: Can't save or open files using Finder dialog on Standard accounts on macOS 10.15 Catalina
            + https://bugs.documentfoundation.org/show_bug.cgi?id=128233
            + started to happen with a new macOS version

         + Text runs of RTL scripts (e.g. Arabic, Hebrew, Persian) from
           imported PDF are reversed, PDFIProcessor::mirrorString not behaving
             + https://bugs.documentfoundation.org/show_bug.cgi?id=104597
             + already listed here for 2 years, and many duplicates
     Fixed:
         + Slow typing with version 7.1 or above on Windows 11
             + https://bugs.documentfoundation.org/show_bug.cgi?id=145963
             + Thanks to Lubos

     + New high severity bugs of the week:
         + Auto Calculate does not work on newly inserted columns in ods or xls formats
             + https://bugs.documentfoundation.org/show_bug.cgi?id=147298
             + Kohei?

* QA stats
     + https://bugs.documentfoundation.org/page.cgi?id=weekly-bug-summary.html
       +152  +2 (-139) overall)
       many thanks to the top bug squashers:
        QA Administrators       18
        Luboš Luňák             12
        Heiko Tietze            10
        Timur                   9
        Buovjaga                7
        Dieter                  5
        Rizal Muttaqin          5
        raal                    5
        Eike Rathke             4
        Michael Warner          4

     + top 10 bugs reporters:
        Telesto                 15
        Anduril                 6
        NISZ LibreOffice Team   5
        titanemdg               5
        Rafael Lima             4
        Mike Kaganski           3
        Robert Großkopf         3
        elias estatistics       3
        Gabor Kelemen (allotropia) 2
        Juergen Funk (CIB)      2

     + top 10 bugs fixers:
        Luboš Luňák             10
        Heiko Tietze            4
        Rafael Lima             4
        Rizal Muttaqin          4
        Henschel, Regina        3
        Adolfo Jayme Barrientos 2
        Kevin Suo               2
        McNamara, Caolán        2
        Rathke, Eike            2
        Sarper Akdemir          2

     + top 10 bugs confirmers:
        Dieter                  19
        Xisco Fauli             13
        Raal                    12
        Ilmari Lauhakangas      8
        m.a.riosv               6
        Heiko Tietze            5
        Nabet, Julien           4
        Olivier Hallot          4
        Ezinne Nnamani          3
        Kelemen, Gabor          3


* Highest-Priority bugs (aka "MABs"):
    + http://bit.ly/2lJAAJI
      6.0 : 1/53 -     1 %  (+0)
      5.4 : 0/41 -     0 %  (+0)
      5.3 : 0/54 -     0 %  (+0)
      5.2 : 0/43 -     0 %  (+0)
      5.1 : 1/36 -     2 %  (+0)
      5.0 : 0/64 -     0 %  (+0)
      4.4 : 0/76 -     0 %  (+0)
      4.3 : 0/73 -     0 %  (+0)
      4.2 : 2/134 -    1 %  (+0)
      4.1 : 3/85 -     3 %  (+0)
      4.0 : 2/83 -     2 %  (+0)
      old : 2/247 -    0 %  (+0)


* Bisected bugs open: keyword 'bisected'
    + more accurate - down to a single commit.
    + http://bit.ly/2dyIfDy
    +

      done by:
         Kelemen, Gabor         3
         Raal                   3
         Aron Budea             2
         Kaganski, Mike         1
         Sarper Akdemir         1


* Bibisected bugs open: keyword 'bibisected'
    + http://bit.ly/2cSCXlS
    +

      done by:
         Kelemen, Gabor         3
         Raal                   3
         Aron Budea             1
         Kaganski, Mike         1
         Sarper Akdemir         1


* all bugs tagged with 'regression'
    + 1255(-6) bugs open of 11589(+16) total 11(+0) high prio.

      done by:
         Raal                   2
         Telesto                2
         Xisco Fauli            2
         Aron Budea             1
         Rathke, Eike           1
         Heiko Tietze           1
         steve -_-              1
         Kaganski, Mike         1
         Németh, László         1
         Sarper Akdemir         1


* ~Component   count net * high severity regressions
    + http://bit.ly/1HWHb3E
      Writer        - 7(+0)
      LibreOffice   - 2(+0)
      Calc          - 1(+0)
      Draw          - 1(+0)

    by OS:
      All           - 9(+0)
      Linux         - 0(+0)
      Mac OS X      - 0(+0)
      Windows       - 2(+0)


* ~Component   count net * all regressions
    + http://bit.ly/1BUdI8i
      Writer: other            - 436(+1)
      Calc                     - 214(-3)
      Impress                  - 127(+3)
      Writer: docx filter      - 57(+0)
      LibreOffice              - 49(+0)
      Crashes                  - 47(-1)
      Draw                     - 44(-1)
      UI                       - 44(+0)
      Borders                  - 39(-1)
      Writer: perf             - 37(+0)
      Writer: other filter     - 35(+0)
      Base                     - 34(+1)
      Chart                    - 28(-1)
      RTL                      - 26(+0)
      Writer: doc filter       - 22(+0)
      Printing and PDF export  - 21(+0)
      BASIC                    - 18(+0)
      graphics stack           - 17(-3)
      filters and storage      - 16(+0)
      Formula Editor           - 2(+0)
      framework                - 1(+0)
      sdk                      - 1(+0)


More information about the LibreOffice mailing list