ESC meeting minutes: 2022-05-26

Miklos Vajna vmiklos at collabora.com
Thu May 26 14:41:39 UTC 2022


* Present:
     + Hossein, Olivier, Cloph, Michael M, Xisco, Miklos, Caolan, Kendy

* Completed Action Items:
     + rename the pootle bot to "Review bot" on gerrit (Ilmari)
     + under-loved areas wiki page (Miklos):
       https://wiki.documentfoundation.org/Development/Under-loved_areas

* Pending Action Items:
     + create a bugzilla query for open easy hacks without the reviewed:2022 whiteboard field (Hossein)
       + closed some, reviewed some
       + to find reviewed easy hacks: https://bugs.documentfoundation.org/buglist.cgi?list_id=1460163&query_format=advanced&resolution=---&status_whiteboard=reviewed%3A2022&status_whiteboard_type=allwordssubstr
          + can find the still relevant ones
          + writing about easy hacks with pictures in the dev-blog (Hossein)
             + whenever we have a public post we get several submissions
             + better ways to present the easy hacks.
          + how does it look when a newbie shows up now ? (Michael)
             + was a horrible zoo of nasty bugs.
             + on the page some are un-reviewed, some needs reviewing (Miklos)
          + bugzilla is a pain to use (Hossein)
             + wiki has an easy list (Michael)
             https://wiki.documentfoundation.org/Development/EasyHacks/by_Required_Skill/Skill_C%2B%2B

* Release Engineering update (Cloph)
     + 7.4 status:
       + beta 1 in 2 weeks + feature freeze
       + late features: SmartArt editing (Thorsten)
     + 7.3 status: 7.3.4 rc2 is 1 week
     + Remotes: Android, iOS
     + Android viewer

* Under-loved areas of the codebase (Michael M)
     + concern that we can't execute quickly on this
     + seems to me the ESC should be recommending areas that are un-loved
       in the code, and ranking them by which are not going to get loved soon.
     + brainstorming next-week instead ? (Cloph)
        + lots of people on holiday
     + how do we feel about a wiki page to collect this stuff ? (Caolan)
        + sounds good (Michael)
        + endangered species kind of list (Caolan)
           + would allow non-ESC members but experts in their own field to have their say
AI:    + will create a wiki page for this before sending the minutes (Miklos)
     + is it an indication - we're going to drop the feature ? (Olivier)
        + concerned re: Math & Base - perhaps Draw
        + no - the opposite (Miklos)
           + we know it is useful - we want to put more resource into it.
           + help the board identify where the best places to invest are (Michael)
     + also useful for oversight (Caolan)
        + to indicate where resources can go if they are available.
     + in docs team - paying attention to base module (Olivier)
        + lots of open issues there - happy to hear we can continue to file
          bugs on base as we document it.

* Documentation (Olivier)
     + New Help
        + Nothing new
     + Helpcontent2
         + Help page fixes (R. Lima, A. Romedenne)
         + Many new bugs on linking dialogs to help pages (ohallot, S. Chaiklin)
           + attention to Base dialogs
     + Guides
         + Published Draw Guide 7.3 (P. Schofield, K. Kriek)
         + Published Math Guide 7.3 in pt-BR (V. Ferreira)

     + Bugzilla Documentation statistics
         238(238) bugs open
     + Updates:
         BZ changes   1 week   1 month   3 months   12 months
            created     16(-2)    49(7)    119(6)      329(9)
          commented     40(20)   105(28)   253(26)    1450(31)
           resolved      1(-2)    14(-1)    62(-2)     210(0)
     + top 10 contributors:
           Seth Chaiklin made 103 changes in 1 month, and 197 changes in 1 year
           Olivier Hallot made 27 changes in 1 month, and 478 changes in 1 year
           Kaganski, Mike made 13 changes in 1 month, and 96 changes in 1 year
           Telesto made 13 changes in 1 month, and 36 changes in 1 year
           Xisco Fauli made 9 changes in 1 month, and 77 changes in 1 year
           Henschel, Regina made 6 changes in 1 month, and 29 changes in 1 year
           Dieter made 5 changes in 1 month, and 96 changes in 1 year
           Heiko Tietze made 5 changes in 1 month, and 76 changes in 1 year
           Leroy made 5 changes in 1 month, and 15 changes in 1 year
           Rafael Lima made 5 changes in 1 month, and 312 changes in 1 year

* UX Update (Heiko)
     + Bugzilla (topicUI) statistics
         277(277) (topicUI) bugs open, 78(78) (needsUXEval) needs to be evaluated by the UXteam
     + Updates:
         BZ changes   1 week    1 month   3 months   12 months
              added       8(5)     13(2)     32(5)       59(4)
          commented     100(36)   292(28)   704(17)    2604(-2)
            removed       0(0)      4(-2)    16(-2)      38(-4)
           resolved      12(5)     31(5)     86(5)      374(3)
     + top 10 contributors:
           Heiko Tietze made 192 changes in 1 month, and 1882 changes in 1 year
           Seth Chaiklin made 75 changes in 1 month, and 187 changes in 1 year
           Telesto made 44 changes in 1 month, and 280 changes in 1 year
           Eyal Rozenberg made 28 changes in 1 month, and 112 changes in 1 year
           Xisco Fauli made 28 changes in 1 month, and 78 changes in 1 year
           Kaganski, Mike made 27 changes in 1 month, and 156 changes in 1 year
           Dieter made 23 changes in 1 month, and 221 changes in 1 year
           Ilmari Lauhakangas made 21 changes in 1 month, and 265 changes in 1 year
           Rafael Lima made 21 changes in 1 month, and 59 changes in 1 year
           Foote, V Stuart made 21 changes in 1 month, and 389 changes in 1 year

* Crash Testing (Caolan)
     + 13(-73) import failure, 3(-12) export failures
       + improved results, glyph caching problems are solved, thanks Lubos
     + 3 coverity issues
       - 2 fixed in gerrit
     + 9 ossfuzz issues
       - 1 crash, 4 OOM/leak, 1 overflow, 3 timeouts
         - high hopes Noel's latest SfxItemSet optimization will
           clear oldest (timeout) issue

* Crash Reporting (Xisco)
    + https://crashreport.libreoffice.org/stats/version/7.2.6.2
          + (-22) 794 816 646 779 781 522 558 428 373 166 0
    + https://crashreport.libreoffice.org/stats/version/7.2.7.2
          + (+101) 268 167 0
    + https://crashreport.libreoffice.org/stats/version/7.3.2.2
          + (-2) 1718 1720 1622 2249 2101 1664 934 0
    + https://crashreport.libreoffice.org/stats/version/7.3.3.2
          + (+362) 1417 1055 555 0


     + Web scraper

     - https://lists.freedesktop.org/archives/libreoffice/2022-May/088917.html

     - gets all the info from the crashreport website, so you can search locally

     - Caolan already fixed some crashes

     - idea is to send it for every new version

       + should help with seeing the trends


* Mentoring/EasyHack update (Hossein)
           committer...   1 week     1 month    3 months    12 months
                   open      91(27)     148(19)    153(20)      156(20)
                reviews     344(108)   1036(34)   3114(-76)   12510(116)
                 merged     325(-9)    1350(99)   3865(-60)   15711(6)
              abandoned      14(-3)      70(4)     299(-14)     832(1)
            own commits     241(-37)   1103(82)   2960(-30)   12552(-31)
         review commits      40(-11)    176(6)     625(-40)    3616(-7)
         contributor...   1 week    1 month     3 months    12 months
                   open      16(-9)     73(-4)      81(-2)       83(-2)
                reviews     842(18)   3128(170)   8978(-48)   34488(10)
                 merged      10(2)      39(-3)     165(-1)     1381(-13)
              abandoned       6(-8)     29(-7)     171(5)       442(2)
            own commits      13(4)      46(4)      193(-3)     1372(-6)
         review commits       0(0)       0(0)        0(0)         0(0)
     + easyHack statistics:
        needsDevEval 8(8)   needsUXEval 2(2)   cleanup_comments 308(308)
        total 368(368)   assigned 19(19)   open 320(320)
     + top 10 contributors:
           xuenhua made 5 patches in 1 month, and 7 patches in 1 year
           Srebotnjak, Martin made 4 patches in 1 month, and 18 patches in 1 year
           Paris Oplopoios made 4 patches in 1 month, and 11 patches in 1 year
           Nagy Tibor made 3 patches in 1 month, and 32 patches in 1 year
           Attila Bakos made 3 patches in 1 month, and 34 patches in 1 year
           Goncharuk, Lera made 2 patches in 1 month, and 2 patches in 1 year
           Marco Pinto made 2 patches in 1 month, and 7 patches in 1 year
           flywire made 2 patches in 1 month, and 10 patches in 1 year
           Daniel Lohmann made 2 patches in 1 month, and 2 patches in 1 year
           Ashleigh Sinclair made 2 patches in 1 month, and 2 patches in 1 year
     + top 10 reviewers:
           Thorsten Behrens made 94 review comments in 1 month, and 810 in 1 year
           McNamara, Caolán made 90 review comments in 1 month, and 540 in 1 year
           Adolfo Jayme Barrientos made 82 review comments in 1 month, and 956 in 1 year
           Michael Stahl made 76 review comments in 1 month, and 1218 in 1 year
           Nabet, Julien made 56 review comments in 1 month, and 606 in 1 year
           Kaganski, Mike made 52 review comments in 1 month, and 712 in 1 year
           Xisco Fauli made 52 review comments in 1 month, and 884 in 1 year
           Heiko Tietze made 44 review comments in 1 month, and 264 in 1 year
           Christian Lohmaier made 40 review comments in 1 month, and 226 in 1 year
           Vajngerl, Tomaž made 38 review comments in 1 month, and 454 in 1 year
     + Patches automatically abandoned: (3 from commiters, 2 from contributors)
         tdf#124430, tdf#137546: sw_uiwriter: Add unittest ( Xisco Fauli )
             - https://gerrit.libreoffice.org/#/c/106852
         Added unit test for tdf#119160 ( Vaibhav Malik )
             - https://gerrit.libreoffice.org/#/c/129983
             - Not buildable, -1 from Jenkins for the written test
         Resolves tdf#45028 - Use background for text on lines ( Heiko Tietze )
             - https://gerrit.libreoffice.org/#/c/131656
         tdf#148109 Paint background color in combobox ( Ilhan Yesil )
             - https://gerrit.libreoffice.org/#/c/131904
             - Have -1 review set by the author
         tdf#148063: basic_macros: Add unittest ( Xisco Fauli )
             - https://gerrit.libreoffice.org/#/c/131939
         + reviewed this list, no valuable / perfect changes were lost
     + big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
           Ashleigh Sinclair
     + LibreOfficeKit question (Hossein)
       + the headers are not part of the binary packages
       + but Debian/Ubuntu packages it
         + sounds like a good idea to put the headers into the SDK (Caolan)
       + https://bugs.documentfoundation.org/show_bug.cgi?id=149256
         https://gerrit.libreoffice.org/c/core/+/134863
         + happy to help with packaging (Cloph)

* GSoC (Hossein/Ilmari)
     + Timeline: https://developers.google.com/open-source/gsoc/timeline
     + https://blog.documentfoundation.org/blog/2022/05/26/projects-selected-for-libreoffice-in-the-google-summer-of-code-2022/
       + 2 projects were selected

* Commit Access
   + None

* Developer Certification (Stephan/Kendy/Thorsten/László)
   + resting since: 20 weeks (limit: 20 weeks)
   + will research candidates (Kendy)

* Jenkins / CI update (Cloph)
     from:Thu May 19 13:56:33 2022
     master linux rel  jobs: 133 ok: 133 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 0.00%
     master linux dbg  jobs: 112 ok: 108 ko:   4 fail ratio:  3.57 % break:   4 broken duration: 3.56%
     master mac rel    jobs:  70 ok:  65 ko:   5 fail ratio:  7.14 % break:   5 broken duration: 7.94%
     master mac dbg    jobs:  74 ok:  69 ko:   5 fail ratio:  6.76 % break:   4 broken duration: 6.87%
     master win rel    jobs:  79 ok:  72 ko:   7 fail ratio:  8.86 % break:   3 broken duration: 8.19%
     master win dbg    jobs:  81 ok:  74 ko:   7 fail ratio:  8.64 % break:   3 broken duration: 8.37%
     master win64 dbg  jobs:  78 ok:  73 ko:   5 fail ratio:  6.41 % break:   4 broken duration: 6.96%
     master gerrit lin jobs: 572 ok: 488 ko:  50 fail ratio:  8.74% time for ok: mean:  21 median:  18
     master gerrit plg jobs: 550 ok: 370 ko: 131 fail ratio: 23.82% time for ok: mean:  41 median:  39
     master gerrit win jobs: 657 ok: 366 ko: 236 fail ratio: 35.92% time for ok: mean:  57 median:  56
     master gerrit mac jobs: 588 ok: 424 ko: 107 fail ratio: 18.20% time for ok: mean:  37 median:  34
     master android    jobs: 531 ok: 446 ko:  49 fail ratio:  9.23% time for ok: mean:  21 median:  14
     master gerrit all jobs: 623 ok: 268 ko: 287 fail ratio: 46.07% time for ok: mean:  79 median:  71
    + https://dev-www.libreoffice.org/tmp/gerrit_220526.html
    + tests that failed more than twice in last seven days
       3 CppunitTest_sw_ooxmlexport3                gerrit_mac
       3 JunitTest_ridl_remote                gerrit_linux_gcc_release
       7 CppunitTest_sw_uiwriter6                gerrit_windows
       7 UITest_calc_tests8                gerrit_linux_clang_dbgutil
       8 UITest_sw_sidebar                gerrit_linux_clang_dbgutil
      11 UITest_impress_tests                gerrit_linux_clang_dbgutil
      15 CppunitTest_vcl_backend_test                gerrit_windows
      17 Killed by the kill-wrapper                gerrit_linux_clang_dbgutil
      20 CppunitTest_sw_uiwriter6                gerrit_mac
      47 CppunitTest_sc_macros_test                gerrit_windows (seems limited to less beefy machines/lower PARALLELISM)
      48 CppunitTest_sdext_pdfimport                gerrit_windows (across all windows machines)
      + still having major problem on Windows with large number of failures
        + CppunitTest_sc_macros_test failures only happen on machines with less cores
        + but now one more machine starts to fail
      + CppunitTest_sdext_pdfimport
        + Noel disabled this on Windows for now (Caolan)

* l10n (Sophie)
   + there was a weblate update (Cloph)
   + notifications are working again (Olivier)

* What’s cooking (Miklos)
   + 16k cols in Calc (Lubos)
     + https://bugs.documentfoundation.org/show_bug.cgi?id=133764
   + feature/chartdatatable: MSO-style data tables for charts (Tomaz)
     + see initial commits in master
   + Working on SmartArt editing (Armin)
   + Adding content controls to Writer (Miklos)
     + inline <w:sdt> in DOCX, rich text/checkbox/dropdown/picture/date types
   + new TIFF filter (Julien)
     + replacing own code with more standard (Caolan)
     + brings in support for e.g. webp-in-tiff
   + gnome dark theme switcher (Caolan)
     + http://caolanm.blogspot.com/2022/05/dark-style-preference-with-gtk.html

* QA update (Xisco)
     + UNCONFIRMED: 1674 (-27)
         + enhancements: 268  (-6)
         + needsUXEval: 6 (+3)
         + haveBackTrace: 7 (+0)
         + needsDevAdvice: 29 (+1)
         + documentation:  26 (+9)
         + android:  3 (-1)
         + iOS:  0 (+0)
         + Online:  11 (+1)

     + Most pressing bugs:
      New:
         None
      Old:
         + macOS: Can't save or open files using Finder dialog on Standard accounts on macOS 10.15 Catalina
            + https://bugs.documentfoundation.org/show_bug.cgi?id=128233
            + started to happen with a new macOS version
            + somebody has to do the work to keep up with the new Apple requirements
              + sometimes this works, sometimes now (Stephan)

     + New high severity bugs of the week:

         + LO crashes on entering-leaving OLE-obj in MacOS on Apple Silicon
           + https://bugs.documentfoundation.org/show_bug.cgi?id=146832
           + possibly not a regression

         + UI: Edit track changes dialog missing buttons (reject/accept)
             + https://bugs.documentfoundation.org/show_bug.cgi?id=147844
             + Tor?
             + Xisco has a fix, will submit to gerrit

         + Business Cards in Writer don't show database
             + https://bugs.documentfoundation.org/show_bug.cgi?id=148978
             + needs bisecting

         + PNG image with alpha channel pasted from clipboard has black background
             + https://bugs.documentfoundation.org/show_bug.cgi?id=98275
             + not a regression?
             + only on Windows, has been there forever

* QA stats
     + https://bugs.documentfoundation.org/page.cgi?id=weekly-bug-summary.html
       +129  -10 (-133) overall)
       many thanks to the top bug squashers:
        Buovjaga                15
        Timur                   13
        Heiko Tietze            10
        Julien Nabet            9
        QA Administrators       9
        Caolán McNamara         8
        Mike Kaganski           8
        Telesto                 5
        Gabor Kelemen (allotropia) 4
        Tünde Tóth              3

     + top 10 bugs reporters:
        Olivier Hallot          7
        Regina Henschel         5
        Telesto                 5
        sdc.blanco              5
        Rafael Lima             4
        BDF                     3
        Gabor Kelemen (allotropia) 3
        Vasily Melenchuk (CIB)  3
        Xisco Faulí             3
        studog                  3

     + top 10 bugs fixers:
        McNamara, Caolán        9
        Heiko Tietze            3
        Melenchuk, Vasily       3
        Tünde Tóth              3
        Bergmann, Stephan       2
        Jim Raykowski           2
        Kelemen, Gabor          2
        Nabet, Julien           2
                                1
        Attila Bakos            1

     + top 10 bugs confirmers:
        Ilmari Lauhakangas      33
        Timur                   11
        Heiko Tietze            7
        Roman Kuznetsov         7
        Dieter                  6
        Henschel, Regina        5
        Nabet, Julien           5
        Raal                    5
        *UNKNOWN*               3
        Bielefeld, Rainer       3

* Highest-Priority bugs (aka "MABs"):
    + http://bit.ly/2lJAAJI
      6.0 : 1/53 -     1 %  (+0)
      5.4 : 0/41 -     0 %  (+0)
      5.3 : 0/54 -     0 %  (+0)
      5.2 : 0/43 -     0 %  (+0)
      5.1 : 1/36 -     2 %  (+0)
      5.0 : 0/64 -     0 %  (+0)
      4.4 : 0/76 -     0 %  (+0)
      4.3 : 0/73 -     0 %  (+0)
      4.2 : 2/134 -    1 %  (+0)
      4.1 : 3/85 -     3 %  (+0)
      4.0 : 2/83 -     2 %  (+0)
      old : 1/246 -    0 %  (+0)

* Bisected bugs open: keyword 'bisected'
    + more accurate - down to a single commit.
    + http://bit.ly/2dyIfDy
    +

      done by:
         Ilmari Lauhakangas     3
         Xisco Fauli            3
         Aron Budea             2
         Timur                  2
         Roman Kuznetsov        1
         Kelemen, Gabor         1
         Weghorn, Michael       1
         Kaganski, Mike         1
         Raal                   1
         Martin Srdoš           1

* Bibisected bugs open: keyword 'bibisected'
    + http://bit.ly/2cSCXlS
    +

      done by:
         Ilmari Lauhakangas     3
         Xisco Fauli            3
         Aron Budea             2
         Martin Srdoš           2
         Roman Kuznetsov        1
         Kelemen, Gabor         1
         Weghorn, Michael       1
         Kaganski, Mike         1
         Raal                   1
         Telesto                1

* all bugs tagged with 'regression'
    + 1264(+7) bugs open of 11805(+25) total 11(-1) high prio.

      done by:
         Telesto                5
         Aron Budea             4
         Ilmari Lauhakangas     3
         Xisco Fauli            3
         Timur                  2
         Roman Kuznetsov        1
         Hossein                1
         Alex Thurgood          1
         Weghorn, Michael       1
         Kaganski, Mike         1

* ~Component   count net * high severity regressions
    + http://bit.ly/1HWHb3E
      Writer        - 6(+0)
      LibreOffice   - 2(+0)
      Calc          - 1(+0)
      Draw          - 1(+0)
      Impress       - 1(+0)
      Installation  - 0(-1)

    by OS:
      All           - 9(+0)
      Linux         - 0(+0)
      Mac OS X      - 0(+0)
      Windows       - 2(-1)

* ~Component   count net * all regressions
    + http://bit.ly/1BUdI8i
      Writer: other            - 465(+0)
      Calc                     - 200(+1)
      Impress                  - 127(+2)
      Writer: docx filter      - 61(+0)
      Crashes                  - 60(+5)
      LibreOffice              - 48(-1)
      Draw                     - 44(+0)
      UI                       - 44(+0)
      Writer: perf             - 39(+0)
      Borders                  - 37(+1)
      Writer: other filter     - 35(+1)
      Base                     - 34(+0)
      Chart                    - 26(+1)
      RTL                      - 25(+1)
      Writer: doc filter       - 21(+0)
      Printing and PDF export  - 20(+0)
      graphics stack           - 17(+0)
      BASIC                    - 16(+0)
      filters and storage      - 16(+0)
      Formula Editor           - 2(+0)
      framework                - 2(+1)
      Linguistic               - 1(+0)
      sdk                      - 1(+0)
      Installation             - 0(-1)


More information about the LibreOffice mailing list