ESC meeting minutes: 2023-02-02

Miklos Vajna vmiklos at collabora.com
Thu Feb 2 15:35:29 UTC 2023


* Present:
     + Cloph, Cosmin, Eike, Heiko, Hossein, Ilmari, Gabriel, Michael W, Michael S, Stephan, Stephane, Xisco, Miklos, Caolan, Thorsten

* Completed Action Items:

* Pending Action Items:
     + install newer NDK on Jenkins to be able to build https://gerrit.libreoffice.org/c/core/+/146118 (Cloph)
     + deploy https://gerrit.libreoffice.org/c/lode/+/143788  "Extend kill-wrapper to also run on macOS" on the Jenkins slaves (Cloph)

* Release Engineering update (Cloph)
     + 7.5 status: 7.5.0 was release as final today; 7.5.1 rc1 in 1 week (tagging / branch)
     + 7.4 status: 7.4.6 rc1 in 2 weeks

* Documentation (Olivier)
     + Missing Olivier
     + Bugzilla Documentation statistics
         258(258) bugs open
     + Updates:
         BZ changes   1 week   1 month   3 months   12 months
            created     11(-5)   44(1)     103(5)      302(-5)
          commented     18(2)    76(10)    306(10)    1044(-12)
           resolved      3(-1)   15(-1)     48(1)      182(-4)
     + top 10 contributors:
           Stéphane Guillou made 67 changes in 1 month, and 124 changes in 1 year
           Olivier Hallot made 32 changes in 1 month, and 418 changes in 1 year
           Ilmari Lauhakangas made 23 changes in 1 month, and 92 changes in 1 year
           Seth Chaiklin made 21 changes in 1 month, and 335 changes in 1 year
           Rafael Lima made 11 changes in 1 month, and 122 changes in 1 year
           Heiko Tietze made 10 changes in 1 month, and 101 changes in 1 year
           Roman Kuznetsov made 9 changes in 1 month, and 59 changes in 1 year
           Kaganski, Mike made 7 changes in 1 month, and 116 changes in 1 year
           Vernon, Stuart Foote made 7 changes in 1 month, and 23 changes in 1 year
           Bogdan B made 6 changes in 1 month, and 179 changes in 1 year

* UX Update (Heiko)
     + Bugzilla (topicUI) statistics
         279(279) (topicUI) bugs open, 70(70) (needsUXEval) needs to be evaluated by the UXteam
     + Updates:
         BZ changes   1 week   1 month   3 months   12 months
              added      9(2)     15(1)     23(1)       60(2)
          commented     55(-5)   234(24)   550(13)    2182(11)
            removed      0(0)      0(0)      7(-1)      32(0)
           resolved      5(-3)    34(2)     82(2)      293(-8)
     + top 10 contributors:
           Heiko Tietze made 169 changes in 1 month, and 1457 changes in 1 year
           Stéphane Guillou made 59 changes in 1 month, and 134 changes in 1 year
           Ilmari Lauhakangas made 51 changes in 1 month, and 203 changes in 1 year
           Dieter made 32 changes in 1 month, and 227 changes in 1 year
           Rafael Lima made 29 changes in 1 month, and 233 changes in 1 year
           Kaganski, Mike made 28 changes in 1 month, and 137 changes in 1 year
           Vernon, Stuart Foote made 25 changes in 1 month, and 161 changes in 1 year
           Seth Chaiklin made 18 changes in 1 month, and 190 changes in 1 year
           David Melik made 15 changes in 1 month, and 16 changes in 1 year
           Eyal Rozenberg made 13 changes in 1 month, and 232 changes in 1 year
     + [Bug 153300] Format->Text menu name is confusing in Calc
  -> + [Bug 153259] Enhancement Request: Exclude some pages from field "Page Count"
       + would be a new page style property: exclude this from counting
       + negative number for the initial page number? (Miklos)
         + that doesn't affect the page count (Heiko)
     + [Bug 153205] Selection should be cleared after moving or copying text by
            dragging/ctrl-dragging
     + [Bug 152744] LO should retain selection on first document when interacting
            with second document
  -> + [Bug 153229] [RFE] Please provide a user preference to disable inheriting
            the system UI theme
       + to override the system default
     + [Bug 153248] Insert Caption and Caption Options dialogs have a mix of
            settings affecting the whole category or only current caption
     + [Bug 153242] Change label "Separator" to "Before Caption" and "Numbering
            separator" to "After numbering" in Caption dialog
     + [Bug 153243] Change label "Numbering Captions by Chapter" to "Numbering by
            Chapter" in Insert - Caption - Options dialog
     + [Bug 150275] Colour toolbar doesn't disappear, if image is deleted or deselected
            (see comment 1)
  -> + [Bug 150239] Selecting whole column to copy data, by accident, freeze - how to
            hard limit numbers of rows when running calc?
       + would be ideal to have a progressbar with a cancel button

* Crash Testing (Caolan)
     + 102(-15) import failure, 5(+0) export failures
     + 0 coverity issues
     + 3 ossfuzz issues

* Crash Reporting (Xisco)
    + https://crashreport.libreoffice.org/stats/version/7.3.7.2
          + (+84) 985 901 840 606 533 431 460 855 217 0
    + https://crashreport.libreoffice.org/stats/version/7.4.3.2
          + (-64) 1055 1119 1463 1790 1246 910 712 0
    + https://crashreport.libreoffice.org/stats/version/7.4.4.2
          + (-149) 1194 1343 832 0
    + https://crashreport.libreoffice.org/stats/version/7.4.5.1
          + (+645) 645 0

    + https://crashreport.libreoffice.org/stats/signature/SwHeaderFooterWin::LinkStubClickHdl(void%20*,weld::Button%20&)

     - No longer reported in 7.4.5.1

     - Other crashes reported in previous versions also fixed


    + https://crashreport.libreoffice.org/stats/signature/void%20rtl::str::release%3C_rtl_uString%3E(_rtl_uString*)

     - back in 7.5.0.3

     - backported in 7.4 branch

     - Noel tried to fix it a couple of times


* Easyhack update (Hossein)
           committer...   1 week     1 month     3 months    12 months
                   open      72(2)      132(-17)    134(-17)     141(-18)
                reviews     346(-30)   1234(80)    3182(38)    11644(-88)
                 merged     315(-62)   1361(207)   3642(32)    14660(-36)
              abandoned      18(1)       70(13)     176(2)       833(3)
            own commits     230(-9)     931(158)   2497(18)    10821(-53)
         review commits      50(12)     230(25)     788(-4)     2845(-19)
         contributor...   1 week     1 month     3 months    12 months
                   open      17(-11)     48(-13)     52(-12)      64(-13)
                reviews     808(-90)   3142(362)   8012(44)    31784(-142)
                 merged       9(-3)      65(5)      241(-1)      870(-3)
              abandoned      15(10)      25(7)      253(11)      569(11)
            own commits      14(0)       88(5)      345(-4)      956(2)
         review commits       0(0)        0(0)        0(0)         0(0)
     + easyHack statistics:
        needsDevEval 9(9)   needsUXEval 1(1)   cleanup_comments 318(318)
        total 383(383)   assigned 18(18)   open 334(334)
     + top 10 contributors:
           Stéphane Guillou made 6 patches in 1 month, and 6 patches in 1 year
           Paris Oplopoios made 5 patches in 1 month, and 92 patches in 1 year
             made 5 patches in 1 month, and 30 patches in 1 year
           Radhey Parekh made 4 patches in 1 month, and 7 patches in 1 year
           Chenxiong Qi made 3 patches in 1 month, and 8 patches in 1 year
           Bogdan B made 3 patches in 1 month, and 86 patches in 1 year
           Ekta Goel made 3 patches in 1 month, and 3 patches in 1 year
           Srebotnjak, Martin made 2 patches in 1 month, and 26 patches in 1 year
           Donkers, Winfried made 2 patches in 1 month, and 3 patches in 1 year
           Shulhan made 2 patches in 1 month, and 2 patches in 1 year
     + top 10 reviewers:
           Vajna, Miklos made 154 review comments in 1 month, and 706 in 1 year
           Michael Stahl made 126 review comments in 1 month, and 1154 in 1 year
           Nabet, Julien made 76 review comments in 1 month, and 780 in 1 year
           Xisco Fauli made 76 review comments in 1 month, and 858 in 1 year
           Adolfo Jayme Barrientos made 74 review comments in 1 month, and 988 in 1 year
           Timar, Andras made 64 review comments in 1 month, and 250 in 1 year
           McNamara, Caolán made 60 review comments in 1 month, and 936 in 1 year
           Grandin, Noel made 56 review comments in 1 month, and 464 in 1 year
           Hossein made 56 review comments in 1 month, and 278 in 1 year
           Thorsten Behrens made 52 review comments in 1 month, and 640 in 1 year
     + Patches automatically abandoned:
         tdf#138302: support for list overrides in DOC export ( Vasily Melenchuk )
             - https://gerrit.libreoffice.org/#/c/116516
         vcl: rename GetOutputOffPixel() to GetFrameOffset() ( Chris Sherlock )
             - https://gerrit.libreoffice.org/#/c/138045
         vcl: use a text and text fill color guard for ImplDrawText() ( Chris Sherlock )
             - https://gerrit.libreoffice.org/#/c/138606
         vcl: rename SalLayout::Draw{Base|Offset}() to Get{Base|Offset}() ( Chris Sherlock )
             - https://gerrit.libreoffice.org/#/c/140555
         vcl: test OutputDevice::GetTextBoundRect() ( Chris Sherlock )
             - https://gerrit.libreoffice.org/#/c/141103
         tdf#142608 Make sure tabs use Dialog Color ( Rafael Lima )
             - https://gerrit.libreoffice.org/#/c/141411
         tdf#141474 tdf#151901 TypeName() Vartype() functions accept keyword arguments ( Alain Romedenne )
             - https://gerrit.libreoffice.org/#/c/142212
         tdf#148017 remove grid widget inside grid1 ( Andreas Kainz )
             - https://gerrit.libreoffice.org/#/c/142499
         tdf#151994 DOCX: fix export of localized formulas ( László Németh )
             - https://gerrit.libreoffice.org/#/c/142552
         tdf#47523 Report & count empty rows when pivoting ( Felipe Lema )
             - https://gerrit.libreoffice.org/#/c/143012
         tdf90341  Clean up excessive const_cast'ing ( Harshita Nag )
             - https://gerrit.libreoffice.org/#/c/143352
         vcl: move functions to AnimationRenderers.cxx in preparation for class split ( Chris Sherlock )
             - https://gerrit.libreoffice.org/#/c/76420
         vcl: extract Animation::RenderersAvailable() ( Chris Sherlock )
             - https://gerrit.libreoffice.org/#/c/76424
         vcl: AnimationRenderer::GetOutSizePix() -> GetSizePx() ( Chris Sherlock )
             - https://gerrit.libreoffice.org/#/c/76428
         vcl: fix equality text (move value to RHS) ( Chris Sherlock )
             - https://gerrit.libreoffice.org/#/c/76458
         vcl: change pObj to pAnmBmp in Animation::Draw() ( Chris Sherlock )
             - https://gerrit.libreoffice.org/#/c/76459
     + big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
           Adoche Onaji
           Gnil Gnay
           Yashodhan Sawardekar

* New EasyHacks (Hossein)
   * QR code improvement: Use ZXing::ToSVG() instead of our own ConvertToSVGFormat() function
     https://bugs.documentfoundation.org/show_bug.cgi?id=153328
   * Use copy_if, find_if or remove_if to simplify loops
     https://bugs.documentfoundation.org/show_bug.cgi?id=153294
* New blog post draft (Hossein)
   * QR code improvement - EasyHack
     https://dev.blog.documentfoundation.org/?p=734&preview=1&_ppp=2cec2170b1

* GSoC (Ilmari)
   + We need more ideas and mentors
   + https://wiki.documentfoundation.org/Development/GSoC/Ideas
     + several new ideas from Heiko, thanks
     + also Jim & Andreas for willing to mentor
   + https://wiki.documentfoundation.org/Development/GSoC/Ideas_without_a_mentor
     + this still needs love
   + application for this year is sent, but the deadline is 7th Feb

* Commit Access

* Developer Certification (Stephan/Kendy/Thorsten/László)
   + resting since: 17 weeks (limit: 20 weeks)

* Jenkins / CI update (Cloph)
gerrit_android_aarch64     jobs: 241 ok: 199 ko:  31 fail ratio: 12.86% mean_ok:  10 ( 22) median_ok:   7 ( 18)
gerrit_android_arm         jobs: 240 ok: 192 ko:  28 fail ratio: 11.67% mean_ok:  11 ( 21) median_ok:   8 ( 15)
gerrit_android_x86         jobs: 240 ok: 199 ko:  30 fail ratio: 12.50% mean_ok:  11 ( 22) median_ok:   8 ( 16)
gerrit_android_x86_64      jobs: 240 ok: 194 ko:  27 fail ratio: 11.25% mean_ok:  11 ( 22) median_ok:   7 ( 15)
gerrit_linux_clang_dbgutil jobs: 499 ok: 285 ko: 176 fail ratio: 35.27% mean_ok:  52 ( 61) median_ok:  50 ( 54)
gerrit_linux_gcc_release   jobs: 480 ok: 381 ko:  68 fail ratio: 14.17% mean_ok:  21 ( 27) median_ok:  20 ( 21)
gerrit_mac                 jobs: 497 ok: 341 ko: 108 fail ratio: 21.73% mean_ok:  39 ( 64) median_ok:  36 ( 45)
gerrit_windows             jobs: 504 ok: 323 ko: 125 fail ratio: 24.80% mean_ok:  63 ( 83) median_ok:  61 ( 70)
gerrit_master              jobs: 529 ok: 236 ko: 228 fail ratio: 43.10% mean_ok:  85 ( 87) median_ok:  73 ( 74)
    + https://dev-www.libreoffice.org/tmp/gerrit_230202.html
    + tests that failed more than twice in last seven days
       3 Killed by the kill-wrapper                gerrit_linux_clang_dbgutil_branch
       3 CppunitTest_sw_a11y                gerrit_linux_gcc_release
       4 CppunitTest_sw_ooxmlexport17                gerrit_mac
       4 JunitTest_sw_unoapi_2                gerrit_linux_clang_dbgutil
       6 CppunitTest_sw_mailmerge                gerrit_windows
       6 UITest_calc_tests8                gerrit_linux_clang_dbgutil
       7 CppunitTest_filter_svg                gerrit_linux_gcc_release
      15 Killed by the kill-wrapper                gerrit_linux_clang_dbgutil

          98f9b51d5878e7a426c1244177d16f49ce639ae4 "Split long-running CppunitTest_sc_opencl_test in two" should help (Xisco)

      17 aborted due to not producing any output to the log                gerrit_mac
   + was a normal, would say (Cloph)

* FOSDEM 2023 (Xisco)
   + Italo is putting together a schedule
     + If you didn't get a mail from Italo, something went wrong (Cloph)
   + Community dinner on Saturday February 4 at ICAB Incubator
   + Hackfest after FOSDEM: on 6 & 7th Feb at ICAB (Xisco)
   + If you are attending, add yourself to https://wiki.documentfoundation.org/Events/2023/FOSDEM
       + limited spots available

* LibreOffice hackfest in Cambridge (Miklos)
   + as part of COOL days: 28 & 29th March 2023
   + Collabora can fund accommodation for people
   + https://www.collaboraoffice.com/cooldays/ has more info

* ESC budget & projects 2023 (Thorsten, Ilmari)
   + Budget document is ready, emailed a Nextcloud link to ESC members (Ilmari)
   + got votes from 8 persons
   + 14 people should still vote ASAP (ideally before FOSDEM)!

* What’s cooking (Miklos)
   + Show popup label for toolbar commands (Heiko)
     + https://gerrit.libreoffice.org/c/core/+/146464
     + tooltips can be quite long, trying to also provide a "popup label"
   + Multi-page fly frames / floating tables (Miklos)
     + very early stage, SW_FORCE_FLY_SPLIT=1 is meant to allow experimenting
   + Infobar improvements for macros (Samuel)
     + if some policy disables the macros, then we still show you a modal dialog -> can't look at the doc (Michael S)

* QA update (Xisco)
     + UNCONFIRMED: 1407 (-65)
         + enhancements: 294  (+2)
         + needsUXEval: 8 (+2)
         + haveBackTrace: 6 (+0)
         + needsDevAdvice: 31 (+0)
         + documentation:  12 (+1)
         + android:  3 (-1)
         + iOS:  0 (+0)
         + Online:  11 (+0)

     + Most pressing bugs:
      New:

     None


     + New high severity bugs of the week:
         + LO75RC1: Automatic spell-check not underlining misspelled words; dialog doesn't use paragraph's language
             + https://bugs.documentfoundation.org/show_bug.cgi?id=152738
             + Fixed by László, will be available in 7.5.1

         + Whole section of Groupedbar Compact UI disappear
             + https://bugs.documentfoundation.org/show_bug.cgi?id=153078
             + Henner?
             + Should it be reverted ? (Xisco)
               + tried to solve it, but it's quite complex (Heiko)
               + at the end would be the same as reverting
               + which problem is worse? (Miklos)
               + 60/40 thing, kind of agree with Xisco

* QA stats (Stéphane)
     + Chennai Bugathon with quite a few comments from beginners, take them with a grain of salt. Ilmari did some cleaning up. Had to de-assign some participants from bugs.
     + New Dark mode meta bug for ones that affect various OSs: https://bugs.documentfoundation.org/show_bug.cgi?id=153293
     + Two different regression crash reports with same ODT document, one on Linux, the other on Windows, both with variety of crash signatures:
        - Windows crash https://bugs.documentfoundation.org/show_bug.cgi?id=153315
          + needs bisecting
        - Linux crash https://bugs.documentfoundation.org/show_bug.cgi?id=153319
          + bisected today
     + Possible 7.5 32-bit crash on startup: https://bugs.documentfoundation.org/show_bug.cgi?id=152346
       + needs bisecting, but unsure how to reproduce it
     + https://bugs.documentfoundation.org/page.cgi?id=weekly-bug-summary.html
       +102  +16 (-132) overall)
       many thanks to the top bug squashers:
        Buovjaga                19
        Stéphane Guillou (stragu) 12
        Heiko Tietze            8
        QA Administrators       8
        Caolán McNamara         7
        Hossein                 7
        Mike Kaganski           7
        Dieter                  4
        Eike Rathke             4
        Telesto                 4

     + top 10 bugs reporters:
        Mike Kaganski           8
        Regina Henschel         6
        Stéphane Guillou (stragu) 4
        sdc.blanco              4
        Gabor Kelemen (allotropia) 2
        Jazzy                   2
        kitchm                  2
        Andreas Neudecker       1
        Andreas Säger           1
        Dan Dascalescu          1

     + top 10 bugs fixers:
        McNamara, Caolán        7
        Heiko Tietze            4
        Kaganski, Mike          3
        Balland-Poirier, Laurent 2
        Grandin, Noel           2
        Kelemen, Gabor          2
        Michael Stahl           2
        Patrick Luby            2
        Samuel Mehrbrodt        2
        Vincent Boudry          2

     + top 10 bugs confirmers:
        Ilmari Lauhakangas      44
        Stéphane Guillou        36
        m.a.riosv               8
        Dieter                  7
        Telesto                 5
        Nabet, Julien           4
        *UNKNOWN*               3
        Heiko Tietze            2
        Henschel, Regina        2
        Kaganski, Mike          2


* Highest-Priority bugs (aka "MABs"):
    + http://bit.ly/2lJAAJI
      6.0 : 2/54 -     3 %  (+2)
      5.4 : 0/41 -     0 %  (+0)
      5.3 : 0/54 -     0 %  (+0)
      5.2 : 0/43 -     0 %  (+0)
      5.1 : 0/35 -     0 %  (+0)
      5.0 : 0/64 -     0 %  (+0)
      4.4 : 0/76 -     0 %  (+0)
      4.3 : 0/73 -     0 %  (+0)
      4.2 : 2/134 -    1 %  (+0)
      4.1 : 2/85 -     2 %  (+0)
      4.0 : 1/82 -     1 %  (+0)
      old : 1/246 -    0 %  (+0)


* Bisected bugs open: keyword 'bisected'
    + more accurate - down to a single commit.
    + http://bit.ly/2dyIfDy
    +

      done by:
         Stéphane Guillou       9
         Raal                   5
         Ilmari Lauhakangas     3
         Kelemen, Gabor         1
         Kaganski, Mike         1
         Telesto                1


* Bibisected bugs open: keyword 'bibisected'
    + http://bit.ly/2cSCXlS
    +

      done by:
         Stéphane Guillou       9
         Raal                   5
         Ilmari Lauhakangas     4
         Kelemen, Gabor         1
         Kaganski, Mike         1
         Telesto                1


* all bugs tagged with 'regression'
    + 1216(+8) bugs open of 12306(+19) total 8(+0) high prio.

      done by:
         Stéphane Guillou       8
         Ilmari Lauhakangas     3
         David                  1
         Kelemen, Gabor         1
         Raal                   1
         Robert Großkopf        1
         Telesto                1
         Vajna, Miklos          1


* ~Component   count net * high severity regressions
    + http://bit.ly/1HWHb3E
      Writer        - 5(+0)
      Calc          - 1(+0)
      Draw          - 1(+0)
      LibreOffice   - 1(+0)

    by OS:
      All           - 7(+0)
      Linux         - 0(+0)
      Mac OS X      - 0(+0)
      Windows       - 1(+0)


* ~Component   count net * all regressions
    + http://bit.ly/1BUdI8i
      Writer: other            - 429(+10)
      Calc                     - 210(-1)
      Impress                  - 127(+2)
      Writer: docx filter      - 59(+1)
      Crashes                  - 49(+0)
      LibreOffice              - 47(+0)
      Draw                     - 43(-1)
      Base                     - 42(+0)
      UI                       - 40(+1)
      Writer: perf             - 35(+0)
      Borders                  - 33(+0)
      Writer: other filter     - 29(+0)
      Chart                    - 25(+0)
      RTL                      - 23(+0)
      Writer: doc filter       - 20(+0)
      Printing and PDF export  - 19(+1)
      BASIC                    - 18(+0)
      filters and storage      - 16(+0)
      graphics stack           - 15(+1)
      Formula Editor           - 3(+0)
      sdk                      - 2(+0)
      Linguistic               - 1(+1)
      framework                - 1(+0)


More information about the LibreOffice mailing list