Hi Michael, I am happy to help out, for now I'll be roaming about the code for a while see if there's something I can do. I think I will focus my efforts around the Calc part, though it might be a bit crowded there :) Also in accordance to the time I have available to me. <div class="gmail_quote">On Thu, Oct 14, 2010 at 10:11 PM, Michael Meeks <<a href="mailto:michael.meeks@novell.com">michael.meeks@novell.com</a>> wrote: <blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">Hi Rene, <div class="im"> On Thu, 2010-10-14 at 19:05 +0200, René Kjellerup wrote: > I've looked through the calc's chart2 source and translated and spell > corrected a few comments in the view code </div> Cool - nice work thanks for that; I pushed it. <div class="im"> > in the ChartItemPool I've added the use of SAL_N_ELEMENTS(array) too </div> Yep; the slight issue here though is that we need to re-arrange the code a bit. Your changes would work, but only if SCH_ATTR_START == 0 - since the range is offset otherwise. It would work if we had: - for( i = SCHATTR_START; i <= SCHATTR_END; i++ ) + for( i = 0; i <= SAL_N_ELEMENTS(pItemInfos); i++ ) { - pItemInfos[i - SCHATTR_START]._nSID = 0; + pItemInfos[i]._nSID = 0; </blockquote><div> yeah that's true... and the same again in the destructor, I'll have a look into it </div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"> etc. ;-) it could perhaps be re-factored like that if you want, but prolly best to compile/test it. Anyhow - thanks for your work ! looking forward to what you work on next - is there any area of LibreOffice you're particularly interested in contributing to ? All the best, Michael. -- <a href="mailto:michael.meeks@novell.com">michael.meeks@novell.com</a> <><, Pseudo Engineer, itinerant idiot </blockquote></div> best wishes René -- -- as life grows older, I gain experience.