<html> <head> <style></style> </head> <body class='hmmessage'> <div><span class="Apple-style-span" style="font-size: 10pt; "><br></span></div><div><span class="Apple-style-span" style="font-size: 10pt; ">Hi Kendy.</span></div><div><span class="Apple-style-span" style="font-size: 10pt; "><br></span></div><div><span class="Apple-style-span" style="font-size: 10pt; ">Thanks again for checking into this. I've done more testing and I think the problem is with your image decoder (ImageMagick). The problem icons are encoded as RGB + Simple 1 'colour' transparency. It may be a bit unusual, but is supported by the PNG spec and works with LibO's png decoder fine. It seems one of the 'Fathers' of the png format- </span><span class="Apple-style-span" style="line-height: 18px; "><span class="Apple-style-span" style="font-size: 10pt; ">Glenn Randers-Pehrson - contributes to </span></span>ImageMagick. If it hasn't been patched already, I'm sure they'd value a bug report.</div><div><br></div><div>I have checked the optimized icons several ways and as much as possible, but ultimately it is only through use we can catch any small oddities. I suggest we push the new icons upstream and await user feedback.</div><div><br></div><div>Many thanks,</div><div>Andrew</div><div><br></div><div><br></div><br>> Subject: RE: [Libreoffice] Image Compression Patch<br>> From: kendy@suse.cz<br>> To: ace_dent@hotmail.com<br>> CC: pat@pathawks.com; libreoffice@lists.freedesktop.org<br>> Date: Sun, 24 Oct 2010 22:07:32 +0200<br>> <br>> Hi Andrew,<br>> <br>> On 2010-10-22 at 11:47 +0100, Andrew C. E. Dent wrote:<br>> <br>> > I've finished the process of lossless optimization for the<br>> > default_images pack.<br>> > The archive is available here:<br>> > http://people.bath.ac.uk/ea2aced/OOo/default_images.zip<br>> <br>> $ du -hs --apparent-size default_images.save/<br>> 6,3M default_images.save/<br>> $ du -hs --apparent-size default_images<br>> 4,8M default_images<br>> <br>> Nice! :-) Thank you a lot!<br>> <br>> To check that everything is still the same, I created a script that<br>> checks 2 directories (original icons, and the optimized ones), converts<br>> the png's to xpm's and checks them for differences:<br>> <br>> http://cgit.freedesktop.org/libreoffice/build/tree/bin/check-artwork.sh<br>> <br>> Unfortunately, some of the icons differed - please see the attached<br>> list; I did not commit/push those, only the ones that were the same.<br>> <br>> Can you please check what was wrong? I eg. see that<br>> svx/res/lightfromleft_22.png has originally a transparent background,<br>> but the optimized version has gray background.<br>> <br>> > I'd be most grateful if you could get this checked in to the<br>> > repository.<br>> <br>> Done :-) - with the exception of the attached list.<br>> <br>> Thank you a lot,<br>> Kendy<br>> <br> </body> </html>