<html> <head> <style></style> </head> <body class='hmmessage'> Hi Joseph<div><br></div><div>That's made my day!</div><div>To make this more manageable, I think we should first agree on how to divide and conquer different aspects.</div><div>A good starting point might be to fix up the fallback code:</div><div> <a href="http://wiki.documentfoundation.org/Easy_Hacks#don.27t_ship_150_duplicate_placeholder_icons">http://wiki.documentfoundation.org/Easy_Hacks#don.27t_ship_150_duplicate_placeholder_icons</a></div><div>Do you use the <span class="Apple-style-span" style="font-family: Monaco, Courier, monospace; font-size: 14px; color: rgb(34, 34, 34); ">#libreoffice IRC channel? Perhaps I can catch you there depending on timezones? </span></div><div><br></div><div>I will compose a more detailed email later, and look forward to working (/hacking) with you.</div><div><br></div><div>Cheers,</div><div>Andrew<br><br></div><div><br></div><div><br>> From: jpowers27@cox.net<br>> Subject: Icons<br>> Date: Mon, 1 Nov 2010 21:15:51 -0700<br>> CC: libreoffice@lists.freedesktop.org<br>> To: ace_dent@hotmail.com<br>> <br>> Andrew,<br>> <br>> I'm a little crazy, but I want to work on the icon issues.<br>> <br>> I'm a programmer, so I've been looking at things from the other side...<br>> <br>> Currently the system is a mess, the top level determines if if we're in high-contrast mode or not and then requests the correct image. On top of this, we have both themed and un-themed icons; thus, I can't just kill the high-contrast checks.<br>> <br>> From your earlier e-mails, you've said that each theme has both standard icons and high-contrast icons; this has to change. However, I'm stuck trying to figure out how the code knows which icon file it's requesting. The un-themed icons in chart2 are easy to tack since I found the mapping files; however, I'm having issues with the themed icons.<br>> <br>> I believe all the themes should be located the /artwork directory and we'll need to create a system for building/packaging them for inclusion into the project. We'll also need to determine a directory to house the installed themes. The current system of themes being hard coded into the build system needs to change; the users should be able to just drop a theme package and have the them auto-reconized on the change theme dialog.<br>> <br>> I'm open to suggestions from any of the other developers.<br>> <br>> I'm also in need of guidance in under standing the current icon packaging system.<br>> <br>> As far as I can determine the biggest savings would be to do the changes in this order:<br>> <br>> 1. Remove the High-Contrast check from the themed icons.<br>> a) This should cut the themes in about half.<br>> b) Reduce a lot of code over head.<br>> 2. Move the un-themed icons in to the default themes. <br>> a) This only removes some redundant code paths for retrieving icons.<br>> b) Removes the last of the High-Contrast checks.<br>> c) Will need to verify that the missing icon fall-back code actually works.<br>> 3. Make themes discoverable.<br>> a) No real savings, it's mostly a coolness factor. Plus it gives the graphics designers something to do so they leave the programmers alone.<br>> <br>> Joe P.<br>> <br></div> </body> </html>