keep up the good work julien :) <div class="gmail_quote">On Fri, Nov 12, 2010 at 4:01 PM, Kohei Yoshida <<a href="mailto:kyoshida@novell.com">kyoshida@novell.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"> Hi Julien, <div class="im"> On Fri, 2010-11-12 at 14:02 +0100, Julien Nabet wrote: > Hello, > > Here's a patch for calc </div>Applied and pushed. Beautifully done. :-) <div class="im"> > I think it's the last one for "calc" since i haven't seen other > "createFromAscii" to remove which concerned litterals. > > In datefunc, i tried to use the syntax : > > rtl::OUString foo(RTL_CONSTASCII_STRINGPARAM("foo")); > > - OUString aImpl = OUString::createFromAscii( "/" ); > + OUString aImpl(RTL_CONSTASCII_USTRINGPARAM( "/" )); > > Hope it's ok and there wasn't other i missed. </div>Yup, that's what we'd have expected. Thanks a lot, and keep them coming! Kohei -- Kohei Yoshida, LibreOffice hacker, Calc <<a href="mailto:kyoshida@novell.com">kyoshida@novell.com</a>> _______________________________________________ LibreOffice mailing list <a href="mailto:LibreOffice@lists.freedesktop.org">LibreOffice@lists.freedesktop.org</a> <a href="http://lists.freedesktop.org/mailman/listinfo/libreoffice" target="_blank">http://lists.freedesktop.org/mailman/listinfo/libreoffice</a> </blockquote></div> -- Jonathan Aquilina