<div>Hi Luke,</div><div><br></div><div><blockquote class="gmail_quote" style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0,8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; ">
I'm very sorry, I should have had this done earlier. Most of it was done Tuesday, but I had trouble building until today</blockquote><div>That's okay, take your time... Getting it to build after messing with something can be rather unpleasant...</div>
</div><div><br></div><div>I think the patch looks great, I've pushed it... But when we need to draw a thin solid line under the visual line that the caret is in, we will probably need to pass a boolean value to SmCursor::Draw in SmGraphicWindow::Paint and from SmCursor::Draw to SmCaretDrawingVisitor... So that only the vertical line blinks, but the solid underline of the visual line doesn't blink...</div>
<div>This is as opposed to not calling SmCursor::Draw in SmGraphicWindow::Paint which is what currently happens...</div><div><br></div><div>By the way, I think that it's really cool that you found the setting for the caret blink timer... Nice work!</div>
<div> - I still have ugly constants for handling key input...</div><div><br></div><div><blockquote class="gmail_quote" style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0,8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; ">
I allowed the initialization of the timer to take place whilst no checking IsInlineEditEnabled(). I'm not sure if that is okay, or perhaps I could think about working out whether it could be initialized if needed if not.</blockquote>
</div><div>I think that is great... initializing the timer can't hurt anybody... And if it's not initialized and the users activates visual editing during runtime, who knows what happens...</div><div> - Well, probably nothing, but nothing isn't good either...</div>
<div><br></div><div><blockquote class="gmail_quote" style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0,8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; ">
These methods that I've made, would you prefer that I write a doxygen <span class="Apple-style-span" style="font-family: arial, sans-serif; font-size: 14px; border-collapse: collapse; color: rgb(68, 68, 68); ">comment for them? </span></blockquote>
</div><div>No, no, don't bother... Leaving them uncommented is fine for stuff of that size... And which such obvious names...</div><div><br></div><blockquote class="gmail_quote" style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0,8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; ">
I'm sending this patch to you, would you prefer I sent it instead to the mailing list?</blockquote><div>As I've pushed the patch I don't think there's any reason to... (I've also CC'ed the list)</div>
<div>Unless, somebody on the list suggests that we don't CC them, I suggest that we do... </div><div>(still send to me, just, CC the list, or the other way around if you prefer that).</div><div><br></div><div>Anyway, thanks for the patch, it's great and it works! :)</div>
<div>If you would move the section about this hack from the Easy_Hacks page to the Easy_Hacks/Completed in the wiki, that would also be great...</div><div><br></div><div>Let me know if you run out of interesting tasks, or get stuck, etc...</div>
<meta http-equiv="content-type" content="text/html; charset=utf-8"><div><br></div>--<br>Regards Jonas Finnemann Jensen.<br>
<br><br><div class="gmail_quote">On Sun, Nov 14, 2010 at 23:08, Luke Dixon <span dir="ltr"><<a href="mailto:6b8b4567@gmail.com">6b8b4567@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
Hello Jonas,<br>
<br>
I'm very sorry, I should have had this done earlier. Most of it was done<br>
Tuesday, but I had trouble building until today (all of it was me<br>
missing something obvious, please don't ask).<br>
<br>
I allowed the initialization of the timer to take place whilst not<br>
checking IsInlineEditEnabled(). I'm not sure if that is okay, or perhaps<br>
I could think about working out whether it could be initialized if<br>
needed if not.<br>
<br>
These methods that I've made, would you prefer that I write a doxygen<br>
comment for them? They are very small and simple, so I wasn't sure it<br>
was worth it.<br>
<br>
I'm sending this patch to you, would you prefer I sent it instead to the<br>
mailing list?<br>
<font color="#888888"><br>
<br>
- Luke<br>
</font></blockquote></div><br>