<div>Hi Luke,</div><div><br></div><div>I've pushed your patch, it looks good and works great...</div><div>Now there's a chance that users will notice that 3 and 4 are in two different lines in the following formula: 3 + 4^2</div>
<div>The way the SmSubSupNode works isn't very intuitive for visual editing (at least compared to MathType), but with this patch people should have a chance to actually notice this obscurity... Thanks! :)</div><div><br>
</div><div><blockquote class="gmail_quote" style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0,8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; ">
I made a couple of methods for SmGraphicWindow, IsLineVisible and <span class="Apple-style-span" style="font-family: arial, sans-serif; font-size: 14px; border-collapse: collapse; color: rgb(68, 68, 68); ">ShowLine. I made them public, as I would imagine they would be used for </span><span class="Apple-style-span" style="font-family: arial, sans-serif; color: rgb(68, 68, 68); ">number 7 of the complex and non-essential tasks on the todo list.</span></blockquote>
<div>That's a great idea, we will probably need that when trying to address that issue...</div><div>(btw, you're welcome to work on the extra dream feature if you feel like it).</div></div><div><br></div><div>As always just move the issue from the easy hacks page, when you're done with it... :)</div>
<div><br></div><div>Again, thanks for a great patch... That's on more off the todo-list...</div><div><br></div>--<br>Regards Jonas Finnemann Jensen.<br>
<br><br><div class="gmail_quote">On Wed, Nov 17, 2010 at 00:43, Luke Dixon <span dir="ltr"><<a href="mailto:6b8b4567@gmail.com">6b8b4567@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
Hello Jonas,<br>
<div class="im">> I think the patch looks great, I've pushed it... But when we need to<br>
> draw a thin solid line under the visual line that the caret is in, we<br>
> will probably need to pass a boolean value to SmCursor::Draw in<br>
> SmGraphicWindow::Paint and from SmCursor::Draw to<br>
> SmCaretDrawingVisitor... So that only the vertical line blinks, but<br>
> the solid underline of the visual line doesn't blink...<br>
> This is as opposed to not calling SmCursor::Draw in<br>
> SmGraphicWindow::Paint which is what currently happens...<br>
<br>
</div>Thanks very much for your help in pointing me in the right direction for<br>
this.<br>
<br>
I've attempted the other easy hack, this information meant I didn't have<br>
to spend any time working out what to do.<br>
I made a couple of methods for SmGraphicWindow, IsLineVisible and<br>
ShowLine. I made them public, as I would imagine they would be used for<br>
number 7 of the complex and non-essential tasks on the todo list.<br>
<div class="im"><br>
> By the way, I think that it's really cool that you found the setting<br>
> for the caret blink timer... Nice work!<br>
</div>That was all thanks to <a href="http://opengrok.go-oo.org" target="_blank">opengrok.go-oo.org</a> (thanks for pointing that out<br>
to me).<br>
<br>
<br>
Regards,<br>
<font color="#888888">Luke<br>
</font></blockquote></div><br>