Hi Michael,<br><br><div class="gmail_quote">Le 22 novembre 2010 22:07, Michael Meeks <span dir="ltr"><<a href="mailto:michael.meeks@novell.com">michael.meeks@novell.com</a>></span> a écrit :<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<br>
Really, of course - I'd love to have someone working on eg.<br>
<br>
<a href="http://wiki.documentfoundation.org/Development/Easy_Hacks#don.27t_ship_150_duplicate_placeholder_icons" target="_blank">http://wiki.documentfoundation.org/Development/Easy_Hacks#don.27t_ship_150_duplicate_placeholder_icons</a><br>
<br>
Which should be mind-numblingly simple and yet yield a real image-size<br>
(and hence performance) win :-)<br>
<br>
Any chance of a small detour on the way ? :-)<br>
<br>
Thanks anyhow,<br>
<div><div></div><div class="h5"><br>
Michael.<br>
<br>
--<br>
<a href="mailto:michael.meeks@novell.com">michael.meeks@novell.com</a> <><, Pseudo Engineer, itinerant idiot<br>
<br>
<br>
</div></div></blockquote></div><br><br>
I will work on this. I see two possible ways:<br>
<br>
- wrap current loadImage with something similar to this:<br>
bool found = loadImage(...)<br>
if (!found) {<br>
found = loadImage( default_icon.png ...)<br>
}<br>
return found<br>
<br>
- alternatively, add the default icon path to the list of paths that are passed to the ImplImageTree::find method.<br>
I think this will be a bit less efficient as the normal case is that the icon exist. Your opinion?<br>
<br>
<br>
Furthermore, the duplicate icons currently exist in several (4?) sizes. So we could have 5 different icons:<br>
lc_default_icon.png<br>
lx_default_icon.png<br>
sc_default_icon.png<br>
sx_default_icon.png<br>
default_icon.png<br>
and based on the input name we can return an icon of the correct size.<br>
<br>Does it look ok for you?<br>
<br>
Regards,<br>
Joachim.<br>
<br>
<br>
<br>