<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><font class="Apple-style-span" face="Arial">I'm converting ScRangeList from "DECLARE_LIST( ScRangeListBase, ScRange* ) " to "::STD::vector< ScRange*> ScRangeListBase"</font><div><font class="Apple-style-span" face="Arial"><br></font></div><div><font class="Apple-style-span" face="Arial">The most of the code boring and unlikely to cause issues; however, some areas need further review:</font></div><div><font class="Apple-style-span" face="Arial"><br></font></div><div><font class="Apple-style-span" face="Arial">sc/source/core/tool/rangelst.cxx</font><span class="Apple-tab-span" style="white-space:pre"><font class="Apple-style-span" face="Arial"> </font></span><font class="Apple-style-span" face="Arial"><- This is the main class ScRangeList and a child of ScRangeListBase. If this is wrong, we're in trouble.</font></div><div><span class="Apple-tab-span" style="white-space:pre"><font class="Apple-style-span" face="Arial"> </font></span><font class="Apple-style-span" face="Arial">- I changed GetCellCount() from ULONG to size_t which is more correct. Can someone verify that this doesn't break 64bit builds?</font></div><div><font class="Apple-style-span" face="Arial"><br></font></div><div><font class="Apple-style-span" face="Arial">sc/source/ui/miscdlgs/acredin.cxx</font></div><div><span class="Apple-tab-span" style="white-space:pre"><font class="Apple-style-span" face="Arial"> </font></span><font class="Apple-style-span" face="Arial">- Re-wrote some logic to not use </font><span class="Apple-style-span" style="color: rgb(0, 128, 0); white-space: pre; "><font class="Apple-style-span" face="Arial">iterators</font></span><span class="Apple-style-span" style="white-space: pre; "><font class="Apple-style-span" face="Arial">. A review would be nice.</font></span></div><div><span class="Apple-style-span" style="white-space: pre; "><font class="Apple-style-span" face="Arial"><br></font></span></div><div><span class="Apple-style-span" style="white-space: pre; "><font class="Apple-style-span" face="Arial">sc/source/ui/unoobj/cellsuno.cxx</font></span></div><div><span class="Apple-style-span" style="white-space: pre; "><span class="Apple-tab-span" style="white-space:pre"><font class="Apple-style-span" face="Arial"> </font></span></span><span class="Apple-style-span" style="white-space: pre; "><font class="Apple-style-span" face="Arial">- The is huge with lots of changes.</font></span></div><div><font class="Apple-style-span" face="Arial"><br></font></div><div><font class="Apple-style-span" face="Arial"><br></font></div><div><font class="Apple-style-span" face="Arial">I now pass a few size_t values to sal_Int32 & sal_uInt32 parameters. The Mac build only supports 32bits currently so this isn't an issue. I need someone with a 64bit build machine to review this patch.</font></div><div><font class="Apple-style-span" face="Arial"><br></font></div><div><font class="Apple-style-span" face="Arial">Joe P.</font></div><div><br></div><div><span class="Apple-style-span" style="font-family: Arial; "></span></div></body></html>